Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21885
**[Test build #4231 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4231/testReport)**
for PR 21885 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21885
**[Test build #4231 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4231/testReport)**
for PR 21885 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21885
**[Test build #4230 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4230/testReport)**
for PR 21885 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21885
**[Test build #4230 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4230/testReport)**
for PR 21885 at commit
Github user rezasafi commented on the issue:
https://github.com/apache/spark/pull/21885
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user NiharS commented on the issue:
https://github.com/apache/spark/pull/21885
Chatted with @squito about this. From what I understood from that
discussion, ExternalShuffleService shouldn't be controlled by configurations
passed into a spark application as it is its own
Github user NiharS commented on the issue:
https://github.com/apache/spark/pull/21885
Thanks for the review and feedback! I made the changes, except for the
moving the if clause to the same line as "yarn", unfortunately that does make
the line 104 characters long.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21885
**[Test build #4224 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4224/testReport)**
for PR 21885 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21885
**[Test build #4224 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4224/testReport)**
for PR 21885 at commit
