Github user ajacques commented on the issue:
https://github.com/apache/spark/pull/21889
Are there any other blockers to enabling this by default now that @mallman
fixed the currently known broken queries?
---
-
To u
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/21889
Success! Now where do we stand, @gatorsmile @HyukjinKwon ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94142/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #94142 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94142/testReport)**
for PR 21889 at commit
[`da50429`](https://github.com/apache/spark/commit/d
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #94142 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94142/testReport)**
for PR 21889 at commit
[`da50429`](https://github.com/apache/spark/commit/da
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/21889
Oh dear. I don't know why we're getting all these sigkills. I think we're
going to need another retest...
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94101/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #94101 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94101/testReport)**
for PR 21889 at commit
[`37e0a97`](https://github.com/apache/spark/commit/3
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #94101 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94101/testReport)**
for PR 21889 at commit
[`37e0a97`](https://github.com/apache/spark/commit/37
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/21889
> Anybody else able to reproduce this failure? It succeeded on my developer
machine.
It worked for me, too. Let's see what a retest does.
---
-
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21889
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user ajacques commented on the issue:
https://github.com/apache/spark/pull/21889
Anybody else able to reproduce this failure? It succeeded on my developer
machine.
---
-
To unsubscribe, e-mail: reviews-unsubs
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94073/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #94073 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94073/testReport)**
for PR 21889 at commit
[`37e0a97`](https://github.com/apache/spark/commit/3
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #94073 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94073/testReport)**
for PR 21889 at commit
[`37e0a97`](https://github.com/apache/spark/commit/37
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94037/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #94037 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94037/testReport)**
for PR 21889 at commit
[`89f9e53`](https://github.com/apache/spark/commit/8
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #94037 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94037/testReport)**
for PR 21889 at commit
[`89f9e53`](https://github.com/apache/spark/commit/89
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/21889
> I was able to run the first failing test successfully. Can we get a
retest, please?
@ajacques I just rebased and pushed my branch off of master. Perhaps the
easiest thing to do would be f
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/21889
> These test failures are in Spark streaming. Is this just an intermittent
test failure or actually caused by this PR?
I was able to run the first failing test successfully. Can we get a ret
Github user ajacques commented on the issue:
https://github.com/apache/spark/pull/21889
These test failures are in Spark streaming. Is this just an intermittent
test failure or actually caused by this PR?
---
-
To u
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93952/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #93952 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93952/testReport)**
for PR 21889 at commit
[`be71cd7`](https://github.com/apache/spark/commit/b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #93952 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93952/testReport)**
for PR 21889 at commit
[`be71cd7`](https://github.com/apache/spark/commit/be
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/21889
> This patch fails Scala style tests.
Hi @ajacques. I'm not sure if you're aware of this, but you can run the
scalastyle checks locally with
```
sbt scalastyle
```
---
--
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93932/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #93932 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93932/testReport)**
for PR 21889 at commit
[`887330d`](https://github.com/apache/spark/commit/8
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #93932 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93932/testReport)**
for PR 21889 at commit
[`887330d`](https://github.com/apache/spark/commit/88
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93925/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #93925 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93925/testReport)**
for PR 21889 at commit
[`85e7759`](https://github.com/apache/spark/commit/8
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #93925 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93925/testReport)**
for PR 21889 at commit
[`85e7759`](https://github.com/apache/spark/commit/85
Github user ajacques commented on the issue:
https://github.com/apache/spark/pull/21889
@mallman, sounds good I'll get this PR updated with your latest changes as
soon as I can.
---
-
To unsubscribe, e-mail: reviews
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/21889
> Where does that leave both of these PRs? Do we still want this one with
the code refactoring or to go back to the original? Are there any comments for
this PR that would block merging? I've set th
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21889
If the revert is very risky, we normally change the default from true to
false when the bug is identified in the RC stage.
---
-
Github user ajacques commented on the issue:
https://github.com/apache/spark/pull/21889
Where does that leave both of these PRs? Do we still want this one with the
code refactoring or to go back to the original? Are there any comments for this
PR that would block merging? I've set the
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21889
Im that case, I hope my comments are addressed together before merging it
in. They are non trivial and I dom't usually go with them if there isn't
special reason for it.
---
-
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21889
Normally, we change the default to false or revert the whole PR if the bugs
are found during the RC (release candidate) stage.
---
-
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21889
We are still targeting this to 2.4, but we need to fix all the identified
bugs before merging it.
---
-
To unsubscribe, e-ma
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/21889
Hi @gatorsmile. Where do you see us at this point? Do you still want to get
this into Spark 2.4?
---
-
To unsubscribe, e-mail: r
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21889
Ah, I think that's a bug when this feature is enabled. How about this:
since this PR is open already and that's a bug in the new feature, we can get
this in, I address my comments and he works o
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21889
I mean https://github.com/apache/spark/pull/21320#issuecomment-408271470
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spa
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21889
@gatorsmile, just for clarification, you mean some regressions about
correctness bug in existing features, right?
---
-
To u
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21889
Just FYI, we are unable to merge it if it has a correctness bug.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apac
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21889
> we need to do something to fix the ignored tests, but those tests are in
this PR.
If this one got merged, yes, we could fix them in a separate PR to enable
them. I remember there need
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/21889
> @mallman, if we are all happy here, mind taking a look
https://github.com/apache/spark/pull/21320#issuecomment-408271470 and
https://github.com/apache/spark/pull/21320#issuecomment-406765851
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21889
If there's no objection within few days, let me get this in cc @cloud-fan
and @gatorsmile and make other works and comments separate.
@mallman, if we are all happy here, mind taking a lo
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93646/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #93646 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93646/testReport)**
for PR 21889 at commit
[`4b847ac`](https://github.com/apache/spark/commit/4
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #93646 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93646/testReport)**
for PR 21889 at commit
[`4b847ac`](https://github.com/apache/spark/commit/4b
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21889
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@s
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
101 - 161 of 161 matches
Mail list logo
