Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21946
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21946
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93897/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21946
**[Test build #93897 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93897/testReport)**
for PR 21946 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21946
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21946
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93896/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21946
**[Test build #93896 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93896/testReport)**
for PR 21946 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21946
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21946
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93891/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21946
**[Test build #93891 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93891/testReport)**
for PR 21946 at commit
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21946
+1
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21946
@rdblue This change is pretty isolated. It also LGTM to me.
Since you are fine about the change, I am assuming you are not blocking
this. I will merge this soon.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21946
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21946
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93888/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21946
**[Test build #93888 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93888/testReport)**
for PR 21946 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21946
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21946
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21946
**[Test build #93897 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93897/testReport)**
for PR 21946 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21946
**[Test build #93896 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93896/testReport)**
for PR 21946 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21946
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21946
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21946
**[Test build #93891 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93891/testReport)**
for PR 21946 at commit
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21946
Yeah, I'm fine with this, then.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21946
> ReadSupport and ReadSupportWithSchema -> BatchReadSupportProvider
DataSourceReader -> ReadSupport
Yea, this is what I'm doing in my local branch for the redesign. I'll push
it soon
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21946
@rdblue the plan is, I will have a big PR that implements the redesign.
However, if there is something makes sense even without the redesign, we should
have a separated PR. I think merging
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21946
> a ReadSupportProvider will supply a create method (or anonymousTable) to
return a Table that implements ReadSupport...
I'd prefer the current proposal in
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21946
@cloud-fan, from your comment around the same time as mine, it sounds like
the confusion may just be in how you're updating the current API to the
proposed one. Can you post a migration plan? It
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21946
Isn't this unnecessary after the API redesign?
For the redesign, the `DataSourceV2` or a `ReadSupportProvider` will supply
a `create` method (or `anonymousTable`) to return a `Table` that
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21946
In the new proposal, we just rename `ReadSupport` to
`BatchReadSupportProvider`, so this change is kind of part of the big proposal.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21946
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21946
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/21946
Wouldn't the redo of the API that we're discussing obsolete this?
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21946
cc @rxin @rdblue @jose-torres
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21946
**[Test build #93888 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93888/testReport)**
for PR 21946 at commit
Github user holdensmagicalunicorn commented on the issue:
https://github.com/apache/spark/pull/21946
@cloud-fan, thanks! I am a bot who has found some folks who might be able
to help with the review:@gatorsmile, @zsxwing and @tdas
---
34 matches
Mail list logo
