Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/22160
Closed this PR since we're in favor of
https://github.com/apache/spark/pull/21749
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22160
Yeah that's right, we have had two parallel trees for different Scala
versions just for reasons like this. There is less forked code now than with
2.10 vs 2.11. If you think we can merge all the
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/22160
@srowen Just found Scala 2.12 has a separated REPL implementation which
suffered from message order printing issue too.
Let me change this PR so the Scala 2.12 version is still on 2.12.6
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/22160
@srowen We were overwriting `def loadFiles(settings: Settings) ` in
https://github.com/scala/scala/blob/v2.11.6/src/repl/scala/tools/nsc/interpreter/ILoop.scala#L853
to initialize the Spark context.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22160
By the way the 2.12 build will still fail, so that won't tell you much.
I think we need 2.12.6 to fix a Java 8 related issue? Don't have it handy
though.
Sorry if I'm being dense
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/22160
@gatorsmile I have not find a time yesterday to run tests with Scala 2.12.
I'll try to do it today.
---
-
To unsubscribe,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22160
@dbtsai Have you tried to run it in scala 2.12? We still can do the upgrade
after Apache 2.4 RC.
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22160
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22160
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94978/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22160
**[Test build #94978 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94978/testReport)**
for PR 22160 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22160
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22160
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94977/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22160
**[Test build #94977 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94977/testReport)**
for PR 22160 at commit
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/22160
@gatorsmile we also need to run the tests for 2.12 manually.
@srowen This PR will revert Scala 2.12.6 back to 2.12.4 since 2.12.6 also
removes the hacks we used to initialize Spark. I worry
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22160
I see, doesn't look like we lose a critical fix or improvement with the
down-grade, and this wasn't released in 2.3.x. OK. I prefer to fix-forward,
too, but am neutral on whether the cost of the
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22160
Thank you! @dbtsai Let us see whether this can pass all the tests?
---
-
To unsubscribe, e-mail:
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/22160
Can you add to the pr description why we are reverting? Just copy paste
what you had above. Thanks.
---
-
To unsubscribe, e-mail:
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/22160
Because of the `printWelcome` message regression described in
`https://issues.apache.org/jira/browse/SPARK-25138`, to have our users best
experience, @gatorsmile and I agree that we either revert
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22160
Oh, what went wrong @dbtsai ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22160
**[Test build #94978 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94978/testReport)**
for PR 22160 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22160
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22160
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22160
**[Test build #94977 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94977/testReport)**
for PR 22160 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22160
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22160
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
25 matches
Mail list logo
