Github user gerashegalov commented on the issue:
https://github.com/apache/spark/pull/22213
Thank you for reviews @vanzin @steveloughran @jerryshao @HyukjinKwon
---
-
To unsubscribe, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22213
Merging to master / 2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95934/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22213
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22213
**[Test build #95934 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95934/testReport)**
for PR 22213 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22213
**[Test build #95934 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95934/testReport)**
for PR 22213 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22213
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22213
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22213
**[Test build #95920 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95920/testReport)**
for PR 22213 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22213
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95920/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22213
**[Test build #95920 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95920/testReport)**
for PR 22213 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22213
Seems fine to me too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95826/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22213
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22213
**[Test build #95826 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95826/testReport)**
for PR 22213 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22213
**[Test build #95826 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95826/testReport)**
for PR 22213 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22213
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22213
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95819/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22213
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22213
**[Test build #95819 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95819/testReport)**
for PR 22213 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22213
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95820/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22213
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22213
**[Test build #95820 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95820/testReport)**
for PR 22213 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22213
**[Test build #95820 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95820/testReport)**
for PR 22213 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22213
**[Test build #95819 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95819/testReport)**
for PR 22213 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95786/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22213
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22213
**[Test build #95786 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95786/testReport)**
for PR 22213 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22213
**[Test build #95786 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95786/testReport)**
for PR 22213 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22213
**[Test build #95782 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95782/testReport)**
for PR 22213 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22213
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95782/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22213
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22213
**[Test build #95782 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95782/testReport)**
for PR 22213 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22213
adding @vanzin as well.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22213
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gerashegalov commented on the issue:
https://github.com/apache/spark/pull/22213
rebased
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user steveloughran commented on the issue:
https://github.com/apache/spark/pull/22213
code LGTM. Clearly its a tangible problem, especially for some one-char
option like "myapp.line.separator"
---
-
To
Github user gerashegalov commented on the issue:
https://github.com/apache/spark/pull/22213
@steveloughran Regarding XML format, java.util.Properties has its dedicated
storeTo/loadFromXML methods which Spark does not use, so we don't need to check
this
---
Github user gerashegalov commented on the issue:
https://github.com/apache/spark/pull/22213
thanks for the comment @steveloughran. I'll add more tests for now and see
how the discussion goes from there.
as for transition to UTF it means to be fully correct Spark needs to
Github user steveloughran commented on the issue:
https://github.com/apache/spark/pull/22213
This actually makes sense. We always forget this, but java properties file
format is [more complex than any of us
Github user gerashegalov commented on the issue:
https://github.com/apache/spark/pull/22213
@jerryshao here is my new take on the problem that should be more
acceptable. The premise is that since JDK has already parsed out natural line
delimiters '\r' and '\n', the remaining ones are
Github user gerashegalov commented on the issue:
https://github.com/apache/spark/pull/22213
@witgo please take a look since you worked on #2379
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22213
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22213
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22213
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
45 matches
Mail list logo
