[GitHub] spark issue #22265: [SPARK-25253][PYSPARK][FOLLOWUP] Undefined name: from py...

2018-08-29 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/22265 ah, of course, `_exception_message` is only used in the exception handling, so we never get an error about an undefined name in any of the tests. Ok, thanks for the explanations, I appreciate it!

[GitHub] spark issue #22265: [SPARK-25253][PYSPARK][FOLLOWUP] Undefined name: from py...

2018-08-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22265 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22265: [SPARK-25253][PYSPARK][FOLLOWUP] Undefined name: from py...

2018-08-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22265 I think we should really start to setup the Jenkins for Python coverage report site FYI @shaneknapp --- - To

[GitHub] spark issue #22265: [SPARK-25253][PYSPARK][FOLLOWUP] Undefined name: from py...

2018-08-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22265 Eh, I think Python 3 is used in Jenkins tests .. ``` Running PySpark tests

[GitHub] spark issue #22265: [SPARK-25253][PYSPARK][FOLLOWUP] Undefined name: from py...

2018-08-29 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/22265 thanks, lgtm btw @HyukjinKwon I had expected jenkins testing to catch this ... but are there no tests run on python 3? is python 3 testing still manual from the contributor & reviewer?