[GitHub] spark issue #22308: [SPARK-25304][SQL][TEST] Fix HiveSparkSubmitSuite SPARK-...

2018-09-02 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22308 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22308: [SPARK-25304][SQL][TEST] Fix HiveSparkSubmitSuite SPARK-...

2018-09-02 Thread sadhen
Github user sadhen commented on the issue: https://github.com/apache/spark/pull/22308 @srowen The 2.12 jar is compiled and packaged from `Main.scala` and `MyCoolClass.scala`. Not a copy of 2.10 jar. Diff it, you will verify it. The steps to generate it: ``` mvn

[GitHub] spark issue #22308: [SPARK-25304][SQL][TEST] Fix HiveSparkSubmitSuite SPARK-...

2018-09-02 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22308 @sadhen I mean is this just a copy of the 2.10 jar? what's in the jar? @felixcheung in this case there's a test specifically testing loading of a jar file, so it has to have a jar file to load.

[GitHub] spark issue #22308: [SPARK-25304][SQL][TEST] Fix HiveSparkSubmitSuite SPARK-...

2018-09-01 Thread sadhen
Github user sadhen commented on the issue: https://github.com/apache/spark/pull/22308 @cloud-fan @srowen This PR will make our jenkins build green.

[GitHub] spark issue #22308: [SPARK-25304][SQL][TEST] Fix HiveSparkSubmitSuite SPARK-...

2018-09-01 Thread sadhen
Github user sadhen commented on the issue: https://github.com/apache/spark/pull/22308 see https://github.com/apache/spark/pull/12924 and https://github.com/apache/spark/pull/11744 --- - To unsubscribe, e-mail:

[GitHub] spark issue #22308: [SPARK-25304][SQL][TEST] Fix HiveSparkSubmitSuite SPARK-...

2018-09-01 Thread sadhen
Github user sadhen commented on the issue: https://github.com/apache/spark/pull/22308 Remove the deprecated 2.10 jar. And build a 2.12 jar. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #22308: [SPARK-25304][SQL][TEST] Fix HiveSparkSubmitSuite SPARK-...

2018-09-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22308 Oh what's the change here in the .jar file? just copied the jar file for 2.11/2.10? --- - To unsubscribe, e-mail:

[GitHub] spark issue #22308: [SPARK-25304][SQL][TEST] Fix HiveSparkSubmitSuite SPARK-...

2018-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22308 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22308: [SPARK-25304][SQL][TEST] Fix HiveSparkSubmitSuite SPARK-...

2018-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22308 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95576/ Test PASSed. ---

[GitHub] spark issue #22308: [SPARK-25304][SQL][TEST] Fix HiveSparkSubmitSuite SPARK-...

2018-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22308 **[Test build #95576 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95576/testReport)** for PR 22308 at commit

[GitHub] spark issue #22308: [SPARK-25304][SQL][TEST] Fix HiveSparkSubmitSuite SPARK-...

2018-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22308 **[Test build #95576 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95576/testReport)** for PR 22308 at commit

[GitHub] spark issue #22308: [SPARK-25304][SQL][TEST] Fix HiveSparkSubmitSuite SPARK-...

2018-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22308 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22308: [SPARK-25304][SQL][TEST] Fix HiveSparkSubmitSuite SPARK-...

2018-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22308 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional