[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-08 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22311 ok, thanks for the check. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revi

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-07 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22311 @maropu Let's keep the change of #22320 for a while. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-07 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22311 Can this pr include the revert code for the #22320 change? Or, we should keep the change for safeguard for a while? (I thinks we'd be better to choose the second approach, so this is just a question)

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22311 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95778/ Test PASSed. ---

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22311 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22311 **[Test build #95778 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95778/testReport)** for PR 22311 at commit [`96b4cca`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22311 **[Test build #95778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95778/testReport)** for PR 22311 at commit [`96b4cca`](https://github.com/apache/spark/commit/96

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22311 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2915/

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22311 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-06 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22311 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: rev

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22311 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95605/ Test FAILed. ---

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22311 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22311 **[Test build #95605 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95605/testReport)** for PR 22311 at commit [`96b4cca`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22311 **[Test build #95605 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95605/testReport)** for PR 22311 at commit [`96b4cca`](https://github.com/apache/spark/commit/96

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22311 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2780/

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22311 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-03 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22311 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: rev

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22311 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22311 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95602/ Test FAILed. ---

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22311 **[Test build #95602 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95602/testReport)** for PR 22311 at commit [`96b4cca`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-02 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22311 > We may also need to change the outputColumns in DataWritingCommand afterward, to avoid it is changed after optimization. After second thought, I will create PR to fix `outputColumns` firs

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22311 **[Test build #95602 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95602/testReport)** for PR 22311 at commit [`96b4cca`](https://github.com/apache/spark/commit/96

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22311 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2777/

[GitHub] spark issue #22311: [WIP][SPARK-25305][SQL] Respect attribute name in Collap...

2018-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22311 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma