[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22427 Merged to master/2.4. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22427 Thank you, @maropu ! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22427 Thanks for the explanation! The change looks good to me. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22427 Thank you for review, @maropu . 1. Yes. It's the same. The first one limits the memory usage for write operation. The second one limits the memory usage for compression operation. 2.

[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22427 Just a question; I'm not familiar with both internal logics though, these parameters (`Memory buffer for writing` and `Compression chunk size`) are internally treated in the same manner? Also, they

[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22427 cc @rdblue --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22427 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22427 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96092/ Test PASSed. ---

[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22427 **[Test build #96092 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96092/testReport)** for PR 22427 at commit

[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22427 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22427 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22427 **[Test build #96092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96092/testReport)** for PR 22427 at commit

[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22427 Could you review this, @gatorsmile , @cloud-fan , @dbtsai , @maropu and @wangyum ? --- - To unsubscribe, e-mail: