Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22713
I do not want to take any risk unless you can have a test case to show the
benefit of each change.
---
-
To unsubscribe, e-m
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22713
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22713
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97344/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22713
**[Test build #97344 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97344/testReport)**
for PR 22713 at commit
[`87fc62a`](https://github.com/apache/spark/commit/8
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22713
@gatorsmile thanks for your comment. Honestly I don't see much value in
holding, as we are (nearly always) using semantic equality throughout the
Analyzer/Optimizer. So different expressions with t
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22713
Could we just hold this PR until we can ensure the expression ID are unique
in the whole tree?
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22713
**[Test build #97344 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97344/testReport)**
for PR 22713 at commit
[`87fc62a`](https://github.com/apache/spark/commit/87
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22713
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22713
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3947/
