Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10179
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user anabranch commented on the pull request:
https://github.com/apache/spark/pull/10179#issuecomment-164033878
@jkbradley should be good to go now!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10179#discussion_r47384213
--- Diff: docs/ml-guide.md ---
@@ -455,6 +465,14 @@ val pipeline = new Pipeline()
// Fit the pipeline to training documents.
val model =
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10179#discussion_r47384218
--- Diff: docs/ml-guide.md ---
@@ -471,6 +489,14 @@ model.transform(test)
println(s"($id, $text) --> prob=$prob, prediction=$prediction")
}
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10179#discussion_r47384216
--- Diff: docs/ml-guide.md ---
@@ -455,6 +465,14 @@ val pipeline = new Pipeline()
// Fit the pipeline to training documents.
val model =
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10179#discussion_r47384225
--- Diff: docs/ml-guide.md ---
@@ -938,4 +964,4 @@ model.transform(test)
{% endhighlight %}
-
\ No newline at end of file
+
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10179#discussion_r47384206
--- Diff: docs/ml-guide.md ---
@@ -192,6 +192,16 @@ Parameters belong to specific instances of
`Estimator`s and `Transformer`s.
For example, if we
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10179#discussion_r47384221
--- Diff: docs/ml-guide.md ---
@@ -543,6 +569,7 @@ Pipeline pipeline = new Pipeline()
// Fit the pipeline to training documents.
PipelineModel
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10179#discussion_r47384208
--- Diff: docs/ml-guide.md ---
@@ -455,6 +465,14 @@ val pipeline = new Pipeline()
// Fit the pipeline to training documents.
val model =
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10179#issuecomment-164004692
Thanks for the updates! Just minor comments now.
I agree we need to improve and reorganize the sections explaining
Pipelines; we're working on that in some
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10179#discussion_r47384202
--- Diff: docs/ml-guide.md ---
@@ -140,8 +140,8 @@ If the `Pipeline` had more stages, it would call the
`LogisticRegressionModel`'s
method on the
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10179#discussion_r47393925
--- Diff: docs/ml-guide.md ---
@@ -455,6 +459,17 @@ val pipeline = new Pipeline()
// Fit the pipeline to training documents.
val model =
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10179#issuecomment-164038183
**[Test build #2206 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2206/consoleFull)**
for PR 10179 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10179#issuecomment-164041335
**[Test build #2206 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2206/consoleFull)**
for PR 10179 at commit
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10179#issuecomment-164037898
LGTM pending tests.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user anabranch commented on the pull request:
https://github.com/apache/spark/pull/10179#issuecomment-164013417
@jkbradley should be good to go! Sorry for being such a pain!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10179#discussion_r47389365
--- Diff: docs/ml-guide.md ---
@@ -455,6 +459,17 @@ val pipeline = new Pipeline()
// Fit the pipeline to training documents.
val model =
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10179#issuecomment-164015812
No, no problem. Just 1 more comment left
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/10179#discussion_r47391102
--- Diff: docs/ml-guide.md ---
@@ -455,6 +459,17 @@ val pipeline = new Pipeline()
// Fit the pipeline to training documents.
val model =
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10179#issuecomment-164045402
Merging with master and branch-1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10179#issuecomment-163712455
@anabranch Hm, I may not have been clear enough. The save/load
functionality seems general and important enough that it should go under the
"Main concepts in
Github user anabranch commented on the pull request:
https://github.com/apache/spark/pull/10179#issuecomment-163845286
@jkbradley gotcha! I misinterpreted your last comments, my fault.
One thing I'm confused about though is that the Estimator, Transformer, and
Param section
Github user anabranch commented on the pull request:
https://github.com/apache/spark/pull/10179#issuecomment-163463790
@jkbradley does this work for you by the way?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user anabranch commented on the pull request:
https://github.com/apache/spark/pull/10179#issuecomment-163519922
@BenFradet integrated your feedback thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user BenFradet commented on the pull request:
https://github.com/apache/spark/pull/10179#issuecomment-163518690
LGTM except one minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/10179#discussion_r47194469
--- Diff: docs/ml-guide.md ---
@@ -613,7 +613,49 @@ for row in selected.collect():
{% endhighlight %}
+
+
+## Example: Saving
Github user anabranch commented on the pull request:
https://github.com/apache/spark/pull/10179#issuecomment-162706754
@jkbradley will make those changes shortly.
@BenFradet will make those changes as well.
---
If your project is set up for it, you can reply to this email
27 matches
Mail list logo
