[GitHub] spark pull request: [MINOR][BUILD] Restore to previous branch inst...

2015-07-27 Thread ijuma
Github user ijuma closed the pull request at: https://github.com/apache/spark/pull/7569 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [MINOR][BUILD] Restore to previous branch inst...

2015-07-27 Thread ijuma
Github user ijuma commented on the pull request: https://github.com/apache/spark/pull/7569#issuecomment-125282944 OK, closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [MINOR][BUILD] Restore to previous branch inst...

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7569#issuecomment-125277581 I also don't really have time to work on this, so I've filed https://issues.apache.org/jira/browse/SPARK-9383 so that someone else can follow up on it later. --- If

[GitHub] spark pull request: [MINOR][BUILD] Restore to previous branch inst...

2015-07-23 Thread ijuma
Github user ijuma commented on the pull request: https://github.com/apache/spark/pull/7569#issuecomment-124123399 @JoshRosen, fair enough. Would you like to propose a PR and I can close this one? :) This doesn't really affect me and I don't have free cycles at this point. --- If

[GitHub] spark pull request: [MINOR][BUILD] Restore to previous branch inst...

2015-07-22 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7569#issuecomment-123814178 As a user, I'd like it if the behavior returned me back to whatever `__git_ps1` displays. Here's an excerpt from the relevant bash code: ```bash local

[GitHub] spark pull request: [MINOR][BUILD] Restore to previous branch inst...

2015-07-21 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7569#issuecomment-123429726 @ijuma I'm fairly certain that the current behavior is an oversight. I find the current behavior to be pretty annoying, so I'm glad that someone finally fixed this.

[GitHub] spark pull request: [MINOR][BUILD] Restore to previous branch inst...

2015-07-21 Thread ijuma
Github user ijuma commented on the pull request: https://github.com/apache/spark/pull/7569#issuecomment-123446563 What would be the desired behaviour in that case? The existing one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [MINOR][BUILD] Restore to previous branch inst...

2015-07-21 Thread ijuma
Github user ijuma commented on the pull request: https://github.com/apache/spark/pull/7569#issuecomment-123431612 @JoshRosen Great. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [MINOR][BUILD] Restore to previous branch inst...

2015-07-21 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7569#issuecomment-123439013 Actually, there seems to be one corner-case: ``` git rev-parse --abbrev-ref HEAD ``` returns `HEAD` when I'm already checked out to a

[GitHub] spark pull request: [MINOR][BUILD] Restore to previous branch inst...

2015-07-21 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/spark/pull/7569 [MINOR][BUILD] Restore to previous branch instead of detached commit The right command to get the branch name is `git rev-parse --abbrev-ref HEAD` instead of `git rev-parse HEAD`. The latter

[GitHub] spark pull request: [MINOR][BUILD] Restore to previous branch inst...

2015-07-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7569#issuecomment-123212549 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [MINOR][BUILD] Restore to previous branch inst...

2015-07-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7569#issuecomment-123212882 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [MINOR][BUILD] Restore to previous branch inst...

2015-07-21 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/7569#issuecomment-123218611 CC @JoshRosen I don't know enough to know, but I suspect of course you're right if you've been using this successfully. --- If your project is set up for it, you can

[GitHub] spark pull request: [MINOR][BUILD] Restore to previous branch inst...

2015-07-21 Thread ijuma
Github user ijuma commented on the pull request: https://github.com/apache/spark/pull/7569#issuecomment-12397 @srowen, some output for context: ``` ~/s/spark ❯❯❯ git rev-parse --abbrev-ref HEAD merge-script-fix-restore-to-branch