Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214572245
@davies and @srowen .
I opened a new PR #12677 to monitor `LZ4BlockInputStream.java` file
properly from now.
If we can monitor it, we had better do that.
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214559455
Then, is it possible to remove `LZ4BlockInputStream.java` from
`dev/.rat-excludes` in this PR?
---
If your project is set up for it, you can reply to this email
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214559276
Oh, thank you, @srowen . It really does.
```
spark:license_header$ git diff master --name-only
dev/.rat-excludes
spark:license_header$
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214556361
@davies this should still be able to pass RAT checks though. It has a valid
license header. This is a fine PR @dongjoon-hyun but as long as the text of the
license in
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214513400
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214513406
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214513124
**[Test build #56913 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56913/consoleFull)**
for PR 12665 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214503106
Oh, I see. I overlooked that.
Thank you, @davies !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user dongjoon-hyun closed the pull request at:
https://github.com/apache/spark/pull/12665
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214502099
LZ4BlockInputStream.java is NOT licensed to Apache Software Foundation
(ASF), even it's licensed under Apache License.
---
If your project is set up for it, you can
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214483662
This PR contains only comment updates and moves, and RAT check is passed.
```
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214479711
Hi, @davies .
I made this PR to ask your opinion.
- Can we remove `LZ4BlockInputStream.java` from RAT exclusion file like
other files?
- Can we remove
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12665#issuecomment-214479554
**[Test build #56913 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56913/consoleFull)**
for PR 12665 at commit
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12665
[MINOR][DOCS] Update license header of LZ4BlockInputStream.java and remove
it from RAT exclusion list.
## What changes were proposed in this pull request?
`LZ4BlockInputStream.java`
14 matches
Mail list logo
