Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49401055
QA results for PR 886:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49479172
@manishamde Thanks for adding multiclass support to decision tree! And
thank everyone for the code review!
Merged into master.
---
If your project is set up for
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/886
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49362826
QA tests have started for PR 886. This patch DID NOT merge cleanly!
brView progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16788/consoleFull
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49374489
QA results for PR 886:br- This patch FAILED unit tests.brbrFor more
information see test
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49375184
@manishamde I think the issue is that there are missing ++ operator for
concatenating excludes in the MimaExcludes.scala file. Does adding them fix it?
---
If your
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49375478
@jkbradley Added the operator. The merge with master changed the format and
I did not notice it.
On Thu, Jul 17, 2014 at 3:29 PM, jkbradley
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49375839
QA tests have started for PR 886. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16792/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49382897
QA results for PR 886:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49391235
QA tests have started for PR 886. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16806/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49391256
QA results for PR 886:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49391450
QA tests have started for PR 886. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16807/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49395217
QA results for PR 886:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49395750
@mengxr LGTM. @manishamde Thanks for the fixes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49396157
@jkbradley Thanks! I just made another very minor commit to format
MimaExcludes.scala.
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49396292
QA tests have started for PR 886. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16809/consoleFull
---
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49219179
@manishamde It looks like the MIMA issue may not be fixed right away, so
let's use the exceptions in MimaExcludes.scala for now. Could you please do
that? I believe
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-48998668
@pwendell I modified the title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49077092
@manishamde It looks like MIMA is complaining about binary compatibility.
Could you please check out the errors in the Jenkins log, which give commands,
e.g.:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49084154
QA tests have started for PR 886. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16688/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49095921
QA results for PR 886:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49097254
@manishamde The @DeveloperApi does not seem to have fixed MIMA's
complaints. I think that modifying the spark/project/MimaExcludes.scala file
should do the trick.
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49098644
@jkbradley I will make the changes that you mentioned.
The documentation from the MimaExcludes.scala says the the DeveloperApi
classes will be skipped. May be
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49100250
@manishamde Thanks! I'll look into the MIMA issue. The code looks good,
and it tests fine vs. scikit-learn on some datasets I've tried.
My only comment now is
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49102109
@jkbradley Thanks a lot for taking a look at the MIMA issue. Also many
thanks for testing out versus scikit-learn! I will update the documentation to
speak about
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49104473
@manishamde Apparently MIMA is a bit fragile currently, but is being
worked on: [https://issues.apache.org/jira/browse/SPARK-2069] I added a
subtask for this specific
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/886#issuecomment-49105740
@jkbradley Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
27 matches
Mail list logo
