Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2395
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55848847
Merged, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55839863
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20439/consoleFull)
for PR 2395 at commit
[`3dc53f2`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55839542
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/120/consoleFull)
for PR 2395 at commit
[`3dc53f2`](https://github.com/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55835703
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20439/consoleFull)
for PR 2395 at commit
[`3dc53f2`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55835406
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/120/consoleFull)
for PR 2395 at commit
[`3dc53f2`](https://github.com/a
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55835334
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55814175
LGTMT
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55769901
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55769881
Jenkins LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55705179
I was commenting on a comment, suggesting to also ignore conf/slaves. It is
not in the PR so LGTM.
---
If your project is set up for it, you can reply to this email and h
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55693164
@srowen was your comment about something in the current patch or proposed
in one of the comments? Does this LGTY?
---
If your project is set up for it, you can reply to
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55685415
O.K. I got it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55685364
yeah, @sarutak, ignore slaves means that it will not be versioned, so not
ignore it
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55684771
Hang on, that file is versioned in the repo. I don't think you want to
ignore it! Not without deciding it should be deleted.
---
If your project is set up for it, you ca
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55684653
@sarutak , ok, i will add it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55684053
@scwf Ah, exactly, .template is just a sample. But slaves is a kind of
confs right?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55683698
@sarutak , i think we should not add them to .gitignore, this files is the
sample file we show to users, in future devs may change them according to
updating of master branc
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55681293
@scwf Thanks for your work!
Also how about adding following files to .gitignore?
- conf/slaves
- conf/*.template
---
If your project is set up for it, y
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55677390
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20356/consoleFull)
for PR 2395 at commit
[`3dc53f2`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55671362
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20356/consoleFull)
for PR 2395 at commit
[`3dc53f2`](https://github.com/ap
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55670980
LGTM pending tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55670955
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2395#issuecomment-55566939
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
GitHub user scwf opened a pull request:
https://github.com/apache/spark/pull/2395
[Minor]ignore all config files in conf
Some config files in ```conf``` should ignore, such as
conf/fairscheduler.xml
conf/hive-log4j.properties
conf/metrics.propertie
25 matches
Mail list logo
