Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-133362904
Thanks you for the patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-133093246
[Test build #41327 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41327/consoleFull)
for PR 8309 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-133110092
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-133110094
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-133111955
Actually the annotations on any class variable do not show up in the doc.
Can you please verify?
---
If your project is set up for it, you can reply to this email
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-133091722
@mengxr I just updated the annotation for one class variable
(ChiSqSelector) but it does not show up in the scala doc for variables. (I have
attached a screesshot)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-133091509
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-133091607
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-133109872
[Test build #41327 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41327/console)
for PR 8309 at commit
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-133152209
Good catch! I will take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-133187054
Sent a patch https://github.com/apache/spark/pull/8344 to fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-133190975
Merged into master and branch-1.5. Thanks! Please make a PR that convert
all existing @since tags into @Since annotation (but do not make additional
changes to simplify
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132571063
[Test build #41236 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41236/console)
for PR 8309 at commit
GitHub user MechCoder opened a pull request:
https://github.com/apache/spark/pull/8309
[SPARK-10108] Add since tags to mllib.feature
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MechCoder/spark tags_feature
Alternatively you
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132555433
@mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132555078
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132555178
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132571221
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132571222
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132556766
[Test build #41236 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41236/consoleFull)
for PR 8309 at commit
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132625744
No, for existing PRs, we ask the authors to stay with `@since` tags because
most of them are first-time contributors. For new PRs, we should use `@Since`
annotation
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132624781
I thought we can merge all directly and replace everything at one go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132635201
Great. Will update in some time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132624419
@MechCoder Shall we use `@Since` annotation directly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132773863
[Test build #41278 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41278/console)
for PR 8309 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132773870
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132769535
@mengxr updated.
I wrote a small bash script that would do the conversion automatically, but
there is one corner case that Ihad to take care of maually
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132771993
[Test build #41278 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41278/consoleFull)
for PR 8309 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132773872
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132777473
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132777544
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132769993
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132770031
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132783946
@MechCoder Please also check the following:
1. overridden methods that do not require JavaDoc (if the JavaDoc is the
same as its parent)
2. public variables
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8309#discussion_r37468191
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -31,6 +31,7 @@ import org.apache.spark.rdd.RDD
*
* @param
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132780455
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132785007
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132781609
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132785012
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132780477
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8309#issuecomment-132781606
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
42 matches
Mail list logo
