Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8532
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8532#issuecomment-174656860
I closed this PR. The feature is implemented in #10756.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8532#issuecomment-171223121
Close this PR please @tijoparacka if you're not updating it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8532#issuecomment-159074351
@tijoparacka Ping! Could you please update this based on @mengxr 's
comments and also fix the merge conflicts? Thank you!
---
If your project is set up for it, you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8532#issuecomment-149734436
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8532#issuecomment-149734478
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8532#issuecomment-149733140
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8532#issuecomment-149742709
**[Test build #44015 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44015/consoleFull)**
for PR 8532 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8532#issuecomment-149742815
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8532#issuecomment-149742814
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tijoparacka commented on the pull request:
https://github.com/apache/spark/pull/8532#issuecomment-144802854
Any of you can review this and merge. I may loose track if it is delayed
more.
---
If your project is set up for it, you can reply to this email and have your
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8532#discussion_r38448746
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -178,6 +178,7 @@ private[recommendation] trait ALSParams extends
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8532#issuecomment-136600946
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8532#discussion_r38366177
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -255,64 +262,81 @@ class ALSModel private[ml] (
* preferences
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8532#discussion_r38366437
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -355,6 +382,7 @@ object ALS extends Logging {
* Rating class
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8532#issuecomment-136530629
Made a pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user tijoparacka commented on a diff in the pull request:
https://github.com/apache/spark/pull/8532#discussion_r38385089
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -355,6 +382,7 @@ object ALS extends Logging {
* Rating class
Github user tijoparacka commented on a diff in the pull request:
https://github.com/apache/spark/pull/8532#discussion_r38385069
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -255,64 +262,81 @@ class ALSModel private[ml] (
* preferences
GitHub user tijoparacka opened a pull request:
https://github.com/apache/spark/pull/8532
[SPARK-10264][Documentation, ML] Added Since annotation for ml.recomendation
Added Since annotation for ALS.scala
You can merge this pull request into a Git repository by running:
$ git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8532#issuecomment-136273508
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
20 matches
Mail list logo
