Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140989949
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140989979
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140993216
[Test build #42582 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42582/console)
for PR 8665 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140993321
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140990352
[Test build #42582 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42582/consoleFull)
for PR 8665 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140993322
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-141130107
Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8665
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140666108
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140667194
[Test build #42528 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42528/consoleFull)
for PR 8665 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140673409
[Test build #42528 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42528/console)
for PR 8665 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140673517
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140673515
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140666089
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140715411
@yu-iskw Could you also add `versionadded` to `FPGrowth` and `FreqItemset`?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8665#discussion_r39525805
--- Diff: python/pyspark/mllib/fpm.py ---
@@ -41,8 +41,11 @@ class FPGrowthModel(JavaModelWrapper):
>>> model = FPGrowth.train(rdd, 0.6, 2)
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140196272
We should use version numbers consistently between Python and Scala, and we
do have a few APIs added in minor releases (DataFrames, some ML pipeline APIs).
I would
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140197755
LGTM (using three parts version in MLlib, we could re-visit the SQL parts
later)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user noel-smith commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140199152
Sounds good - thanks for confirming - I'll reinstate the thre-part version
numbers in my PRs.
---
If your project is set up for it, you can reply to this email and
Github user noel-smith commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140185860
@mengxr @davies Just to confirm, before @yu-iskw and I make the changes -
we want to stick with the two-part version numbers (`@since(1.4)`) used in
`pyspark.sql`
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-140187732
@noel-smith I prefer two part version numbers, that's the way python
standard libraries do, but we use three parts in Scala, @mengxr how do you
think?
---
If your
Github user noel-smith commented on a diff in the pull request:
https://github.com/apache/spark/pull/8665#discussion_r39435855
--- Diff: python/pyspark/mllib/fpm.py ---
@@ -41,8 +41,11 @@ class FPGrowthModel(JavaModelWrapper):
>>> model = FPGrowth.train(rdd, 0.6, 2)
Github user noel-smith commented on a diff in the pull request:
https://github.com/apache/spark/pull/8665#discussion_r39436349
--- Diff: python/pyspark/mllib/fpm.py ---
@@ -58,6 +61,7 @@ class FPGrowth(object):
"""
@classmethod
+@since("1.4.0")
Github user noel-smith commented on a diff in the pull request:
https://github.com/apache/spark/pull/8665#discussion_r39436251
--- Diff: python/pyspark/mllib/fpm.py ---
@@ -41,8 +41,11 @@ class FPGrowthModel(JavaModelWrapper):
>>> model = FPGrowth.train(rdd, 0.6, 2)
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-138815465
@mengxr unfortunately, a class which inherits from `object` doesn't work.
And as I commented on
[SPARK-10276](https://issues.apache.org/jira/browse/SPARK-10276), it
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-138801343
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-138801410
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-138828459
It seems that it works well with a class which inherits from `object` under
python 3.3 or later. At least, it doesn't work under python 2.6.8, 2.7, 3.2 .
---
If your
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-138812017
Does `@since` work on classes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-138802723
[Test build #42191 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42191/consoleFull)
for PR 8665 at commit
GitHub user yu-iskw opened a pull request:
https://github.com/apache/spark/pull/8665
[SPARK-10274][MLlib] Add @since annotation to pyspark.mllib.fpm
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yu-iskw/spark SPARK-10274
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-138806175
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-138806077
[Test build #42191 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42191/console)
for PR 8665 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-138806174
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-138943049
I think we should add that to the docstring of class, the class methods
already had it, isn't it?
---
If your project is set up for it, you can reply to this email and
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-138939964
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-138942322
@davies thank you for the comment. Just to be sure, we should add `..
addedversion:: 1.4` to class methods, right?
---
If your project is set up for it, you can reply
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-138936212
@davies do you have any good idea about the above issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-139094443
Right. I understand `@since` depends on an order of decorators. `@since`
should be called before `@classmethod`.
```
# Work
@classmethod
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-139096852
@mengxr could you review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-139097038
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-139097050
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-139097678
[Test build #42230 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42230/consoleFull)
for PR 8665 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-139100415
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-139100412
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8665#issuecomment-139100371
[Test build #42230 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42230/console)
for PR 8665 at commit
46 matches
Mail list logo
