Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8700
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-146987818
LGTM, merging this into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user smartkiwi commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-146665724
Test passes. Any feedback on this? Or can this be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-144215760
[Test build #1826 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1826/console)
for PR 8700 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-144180554
[Test build #1826 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1826/consoleFull)
for PR 8700 at commit
Github user smartkiwi commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-142287774
This fixes pyspark tests.
Please test this again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-142180737
[Test build #1783 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1783/consoleFull)
for PR 8700 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-142184249
[Test build #1783 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1783/console)
for PR 8700 at commit
Github user smartkiwi commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-142152718
Please test this again - there were some github connection issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-142094998
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-142095847
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-142099277
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-142095875
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-142099272
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user smartkiwi commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-142093257
Ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user smartkiwi commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-141793243
Jenkins please test again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-140498376
[Test build #1756 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1756/console)
for PR 8700 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-140489529
[Test build #1756 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1756/consoleFull)
for PR 8700 at commit
Github user smartkiwi commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-140479983
@davies ping
Can somebody verify this? Jenkins have't started tests for this pull
requests
---
If your project is set up for it, you can reply to this email and
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8700#discussion_r39553301
--- Diff: python/pyspark/mllib/recommendation.py ---
@@ -156,6 +166,18 @@ def recommendProducts(self, user, num):
"""
return
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8700#discussion_r39553069
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/api/python/MatrixFactorizationModelWrapper.scala
---
@@ -42,4 +42,15 @@ private[python] class
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8700#discussion_r39553213
--- Diff: python/pyspark/mllib/recommendation.py ---
@@ -85,6 +85,16 @@ class MatrixFactorizationModel(JavaModelWrapper,
JavaSaveable, JavaLoader):
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8700#discussion_r39553076
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/api/python/MatrixFactorizationModelWrapper.scala
---
@@ -42,4 +42,15 @@ private[python] class
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-139602565
@smartkiwi Sorry, my comments duplicate @davies 's ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user smartkiwi commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-139605916
@mengxr, @davies thanks for a hints
I'm rather new with Scala, and very interested into learning it further.
I've found the code with Python wrapper used
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8700#discussion_r39292344
--- Diff: python/pyspark/mllib/recommendation.py ---
@@ -156,6 +162,18 @@ def recommendProducts(self, user, num):
"""
return
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8700#discussion_r39292338
--- Diff: python/pyspark/mllib/recommendation.py ---
@@ -85,6 +85,12 @@ class MatrixFactorizationModel(JavaModelWrapper,
JavaSaveable, JavaLoader):
Github user smartkiwi commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-139653064
Ok
Please see this update - I've added methods for converting Tuple to Array
into MatrixFactorizationModelWrapper
Could you please review this pull
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-139287240
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user smartkiwi opened a pull request:
https://github.com/apache/spark/pull/8700
[SPARK-10535] Sync up API for matrix factorization model between Scala and
PySpark
Support for recommendUsersForProducts and recommendProductsForUsers in
matrix factorization model for PySpark
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-139403576
Oh, I missed that part.
You could add a wrapper in Scala (PythonMLLibAPI) to convert RDD[Tuple]
into RDD[Array[Any]], and call the wrapper from Python.
---
If
Github user smartkiwi commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-139398333
I've added these methods doc string
Acually it is not that useful as it is now - as it returns "scala.Tuple2"
strings - and not as in scala (Int, Array[Rating])
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-139377677
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8700#issuecomment-139377664
OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
34 matches
Mail list logo
