Github user bharath-official commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-221446395
@vectorijk Oh great then! That makes sense. Thanks for your inputs Kai.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vectorijk commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-221444959
@bharath-official I don't think it's really necessary because it was
changed in Spark 2.0
---
If your project is set up for it, you can reply to this email and have
Github user bharath-official commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-221442950
@vectorijk Yes you are right. It works fine but throws a warning which I
am trying to avoid. Would it make sense if I go ahead and look at the transform
code
Github user vectorijk commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-221440730
@bharath-official You're right.
Aha. Like you said, it should work fine if this warning message just shows
during the process of calling model.
---
If your
Github user bharath-official commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-221439566
@vectorijk Yes you are right Kai it is a warning that is thrown and not an
error. The function also seems to work as expected. Since this use case gets
Github user vectorijk commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-221437455
@bharath-official Try to use coefficients instead. This is warning
information. Did you get error message?
---
If your project is set up for it, you can reply to
Github user bharath-official commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-221436872
Hi Kai
I am trying to build a learning model in Spark 1.6 and I think I am hitting
a bug related to this deprecation.
This is our sample
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9311#discussion_r43724499
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/AFTSurvivalRegression.scala
---
@@ -227,10 +227,10 @@ class AFTSurvivalRegression
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9311#discussion_r43690512
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala
---
@@ -51,13 +51,22 @@ private[r] object SparkRWrappers {
pipeline.fit(df)
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-153174243
LGTM except one minor issue. @dbtsai Do you have time to make another pass?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9311#discussion_r43690639
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/IsotonicRegression.scala ---
@@ -87,8 +87,8 @@ private[regression] trait IsotonicRegressionBase
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9311
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9311#discussion_r43694864
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -392,11 +392,14 @@ class LogisticRegression(override val
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-153198286
No, that is a compatible change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-153200678
Thanks. Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-153201019
@dbtsai The comment on `LogisticRegressionAggregator` is not addressed
yet. Could you send a PR to fix it?
---
If your project is set up for it, you can reply to this
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9311#discussion_r43694980
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala
---
@@ -51,13 +51,22 @@ private[r] object SparkRWrappers {
pipeline.fit(df)
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-153183047
This looks good to me, but I wonder if changing from `val weights` into
`def weights: Vector = coefficients` will cause any binary compatibility issue.
---
If your
Github user vectorijk commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-153205774
Thanks @mengxr @dbtsai !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/9311#discussion_r43704773
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala
---
@@ -51,13 +51,22 @@ private[r] object SparkRWrappers {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-152482737
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-152482739
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user vectorijk commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-152478398
didn't deprecate `weights` under `spark/ml` related to `weights` in
`Layer.scala`. cause I think `weights` do mean weight in
`spark/ml/ann/Layer.scala`
---
If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-152482348
**[Test build #44675 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44675/consoleFull)**
for PR 9311 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-152513787
**[Test build #44680 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44680/consoleFull)**
for PR 9311 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-152512550
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-152512537
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-152525456
**[Test build #44680 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44680/consoleFull)**
for PR 9311 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-152525731
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-152525727
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-151669474
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-151669394
You can trace all `weights` calls in an IDE. For example, I found this:
`/Users/meng/src/spark/mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala:54`.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-151669476
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-151659609
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-151659638
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user vectorijk opened a pull request:
https://github.com/apache/spark/pull/9311
[SPARK-10592] [ML] [PySpark] Deprecate weights and use coefficients instead
in ML models
Deprecated in `LogisticRegression` and `LinearRegression`
You can merge this pull request into a Git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-151661375
**[Test build #44470 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44470/consoleFull)**
for PR 9311 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-151669366
**[Test build #44470 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44470/consoleFull)**
for PR 9311 at commit
Github user vectorijk commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-151672707
Thanks! It seems like I missed some. I will trace and keep on deprecation.
---
If your project is set up for it, you can reply to this email and have your
reply
39 matches
Mail list logo
