[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140588861 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140588864 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140588787 [Test build #42512 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42512/console) for PR 8761 at commit [`90f7943`](https://github.

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8761 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140582912 Actually this patch is essentially a no-op so I'm just going to merge it. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140576113 [Test build #42512 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42512/consoleFull) for PR 8761 at commit [`90f7943`](https://gith

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140575405 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140575460 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140573196 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140488344 [Test build #42493 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42493/console) for PR 8761 at commit [`90f7943`](https://github.

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140488398 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140488397 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140481364 [Test build #42493 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42493/consoleFull) for PR 8761 at commit [`90f7943`](https://gith

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140480836 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140480856 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140480137 OK updated - I put everything in LocalNode. I was initially thinking it might be better to be more explicit - but it seems vast majority of the operators don't need

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/8761#discussion_r39540741 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/local/ConvertToSafeNode.scala --- @@ -27,6 +27,10 @@ case class ConvertToSafeNode(conf: SQLConf

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/8761#discussion_r39516919 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/local/HashJoinNode.scala --- @@ -73,6 +73,11 @@ case class HashJoinNode( } }

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/8761#discussion_r39516786 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/local/ConvertToSafeNode.scala --- @@ -27,6 +27,10 @@ case class ConvertToSafeNode(conf: SQLC

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140351670 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140351674 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140351568 [Test build #42475 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42475/console) for PR 8761 at commit [`f2d4a1d`](https://github.

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140312703 [Test build #42475 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42475/consoleFull) for PR 8761 at commit [`f2d4a1d`](https://gith

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140312011 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140312029 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/8761 [SPARK-10612][SQL] Add prepare to LocalNode. The idea is that we should separate the function call that does memory reservation (i.e. prepare) from the function call that consumes the input (e.g. open