Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-175768840
LGTM. I am merging it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8969
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-175770352
I also merged it in branch 1.5 and branch 1.6 since it is very isolated bug
fix.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user skparkes commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-175775385
Thanks a bunch guys, this will be a big help.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-175338290
Ping @yhuai, is this ready for merging?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-175338382
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-175341869
**[Test build #50160 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50160/consoleFull)**
for PR 8969 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-175369175
**[Test build #50160 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50160/consoleFull)**
for PR 8969 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-175370154
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-175370156
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8969#discussion_r49628004
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Metadata.scala ---
@@ -229,6 +231,9 @@ class MetadataBuilder {
this
}
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-171387160
@jasoncl Can you do a quick update if my comment makes sense? Then, we will
get it merged. Thanks!
---
If your project is set up for it, you can reply to this email and
Github user jasoncl commented on a diff in the pull request:
https://github.com/apache/spark/pull/8969#discussion_r49683600
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Metadata.scala ---
@@ -229,6 +231,9 @@ class MetadataBuilder {
this
}
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-150659611
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-150659658
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-150662280
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-150662279
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-150656437
[Test build #44243 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44243/consoleFull)
for PR 8969 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-150660369
**[Test build #44246 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44246/consoleFull)**
for PR 8969 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-150682844
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-150682712
**[Test build #44246 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44246/consoleFull)**
for PR 8969 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-150682842
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-150696360
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-150696226
[Test build #44243 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44243/console)
for PR 8969 at commit
Github user jasoncl commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-150701775
The test build #44243 for commit 978fdc7 shows that the patch does not
merge cleanly. But that is not my latest commit. My latest commit 5524a92 has
passed the test
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-150696362
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-150654189
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-150654205
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-150658469
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-150658487
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-149046745
Jenkins, this is ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8969#discussion_r42326412
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Metadata.scala ---
@@ -228,6 +232,8 @@ class MetadataBuilder {
map ++=
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-149046930
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-149046921
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-149047792
This seems good overall, but one high-level question: why store `None` on
the Java side instead of `null`? I'm just wondering whether mapping it back to
Java `null`
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-149064191
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-149064113
[Test build #43900 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43900/console)
for PR 8969 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-149064189
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-149047716
[Test build #43900 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43900/consoleFull)
for PR 8969 at commit
GitHub user jasoncl opened a pull request:
https://github.com/apache/spark/pull/8969
[SPARK-10847] [SQL] [PySpark] Pyspark - DataFrame - Optional Metadata with
`None` triggers cryptic failure
The error message is now changed from "Do not support type class
scala.Tuple2." to "Do
Github user skparkes commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-145189331
Thanks for doing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-145177726
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
42 matches
Mail list logo
