[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2016-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-215666176 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2016-01-18 Thread tristanreid
Github user tristanreid commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-172606537 Anyone know the status of this change? Is there anything blocking, or was it superceded by something else? Thanks... --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-11-16 Thread sureshthalamati
Github user sureshthalamati commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-156954717 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-11-04 Thread rick-ibm
Github user rick-ibm commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-153823011 Thanks for addressing the SQL injection concerns, Suresh. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-30 Thread sureshthalamati
Github user sureshthalamati commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152683286 retest this please. Test failure is unrelated to my changes. Failed test is org.apache.spark.sql.sources.JsonHadoopFsRelationSuite.test all data types

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152623785 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152623769 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-30 Thread sureshthalamati
Github user sureshthalamati commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152624863 Updated the patch to address sql injection issue by removing space characters from the input. Please review. @marmbrus @rxin --- If your project is

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152626002 **[Test build #44699 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44699/consoleFull)** for PR 9352 at commit

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152653173 **[Test build #44699 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44699/consoleFull)** for PR 9352 at commit

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152653232 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152653229 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152169589 **[Test build #44586 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44586/consoleFull)** for PR 9352 at commit

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152169728 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152169726 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-29 Thread sureshthalamati
Github user sureshthalamati commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152273675 Failed test is test_trainOn_predictOn (__main__.StreamingKMeansTest). It seems to be unrelated to my changes. Can we retest this please. --- If your

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-29 Thread sureshthalamati
GitHub user sureshthalamati opened a pull request: https://github.com/apache/spark/pull/9352 [SPARK-10849][SQL] Adding field metadata property to override default jdbc data source type mapping. This patch allows users to override default type mapping of data frame field to

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152112655 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-29 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152142416 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152145309 **[Test build #44586 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44586/consoleFull)** for PR 9352 at commit

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152143301 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152143323 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-29 Thread sureshthalamati
Github user sureshthalamati commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152373735 Thinking about this more , I realized current version of the patch may introduce SQL injection. I will update the pull request with a new version of the fix.