[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-216600951 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-153842578 **[Test build #45027 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45027/consoleFull)** for PR 9202 at commit

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-153842920 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-153842921 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-153806475 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-153806547 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-153807176 **[Test build #45027 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45027/consoleFull)** for PR 9202 at commit

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user rick-ibm commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-152661995 Thanks for the quick response, Michael. Simply parenthesizing the query will result in non-Standard syntax which an ANSI-compliant database will reject... //

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user rick-ibm commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-152542748 Any further refinements which I should make to this patch? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-152588761 @rick-ibm, thanks for working on this. With the Spark Summit just wrapping up and code freeze for 1.6 tomorrow I don't think there is going to be a lot of review

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-152648785 You have to put the subquery in parentheses so it results in valid SQL. On Oct 30, 2015 9:06 PM, "Rick Hillegas" wrote: > Thanks

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user rick-ibm commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-152638711 Thanks for that feedback, Michael. To answer your question: MA> I haven't looked closely at the implementation, but one high level question is whether this is

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-151608474 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user rick-ibm commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-151608061 Thanks for the advice about how to improve this patch, Sean. Hopefully, my last commit addresses your concerns. I have made the following changes: 1)

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-151641902 **[Test build #44457 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44457/consoleFull)** for PR 9202 at commit

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-151642085 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-151642087 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-151608509 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-151610388 **[Test build #44457 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44457/consoleFull)** for PR 9202 at commit

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9202#discussion_r42854130 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/SqlIdentifierUtil.java --- @@ -0,0 +1,322 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150304899 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150304731 **[Test build #44156 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44156/consoleFull)** for PR 9202 at commit

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150304893 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9202#discussion_r42743556 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/SqlIdentifierUtil.java --- @@ -0,0 +1,322 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9202#discussion_r42743817 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/SqlIdentifierUtil.java --- @@ -0,0 +1,322 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9202#discussion_r42743770 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala --- @@ -86,19 +94,58 @@ abstract class JdbcDialect { * name is a

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user rick-ibm commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150267546 Thanks for the review comments, Sean. I did not polish the Java code in SqlIdentifierUtil, and I didn't translate it into Scala. This was in the interests of

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150269081 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150269103 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150270090 **[Test build #44156 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44156/consoleFull)** for PR 9202 at commit

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

GitHub user rick-ibm opened a pull request: https://github.com/apache/spark/pull/9202 [SPARK-10857] [SQL] Block SQL injection vulnerabilities under DataFrameWriter.jdbc(). @marmbrus @rxin @joshrosen @srowen This patch attempts to address both

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-149997285 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150016295 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150020934 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150025997 Transient networking issues. test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150027189 **[Test build #44094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44094/consoleFull)** for PR 9202 at commit

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150027762 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150017407 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150020938 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user rick-ibm commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150025478 According to the log for the build/test cycle, a git pull request succeeded... GitHub pull request #9202 of commit b3b845de9960e003637d26fecaf8dccaa0206f59

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150026822 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150032928 ``` Scalastyle checks failed at following occurrences: [error]

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150017438 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150026844 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150027760 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150027756 **[Test build #44094 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44094/consoleFull)** for PR 9202 at commit

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user rick-ibm commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150032606 The following style tests ran cleanly for me: build/sbt scalastyle What other style tests should I run? Thanks, -Rick --- If your

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150043998 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150043989 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user rick-ibm commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150043741 Thanks, Josh. My last commit should address that long line problem. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150045688 **[Test build #44096 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44096/consoleFull)** for PR 9202 at commit

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150064704 **[Test build #44096 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44096/consoleFull)** for PR 9202 at commit

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150064995 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10857] [SQL] Block SQL injection vulner...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9202#issuecomment-150064993 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your