Github user staple commented on a diff in the pull request:
https://github.com/apache/spark/pull/2385#discussion_r17528982
--- Diff: python/pyspark/traceback_utils.py ---
@@ -0,0 +1,80 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2385#discussion_r17557557
--- Diff: python/pyspark/traceback_utils.py ---
@@ -0,0 +1,80 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2385#issuecomment-55646967
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20348/consoleFull)
for PR 2385 at commit
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2385#issuecomment-55687151
This looks good to me, so I'm going to merge it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2385
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user staple commented on the pull request:
https://github.com/apache/spark/pull/2385#issuecomment-55687608
Great! Thanks to all the reviewers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2385#issuecomment-55516585
Jenkins, this is ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2385#issuecomment-55516625
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20300/consoleFull)
for PR 2385 at commit
Github user jyotiska commented on the pull request:
https://github.com/apache/spark/pull/2385#issuecomment-55517066
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user staple commented on the pull request:
https://github.com/apache/spark/pull/2385#issuecomment-55526943
Hi, the above failure in NetworkReceiverSuite.scala seems like it may be
unrelated to this patch. That test also passed when I ran locally.
---
If your project is set up
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2385#issuecomment-55542730
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/104/consoleFull)
for PR 2385 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2385#issuecomment-55544330
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/104/consoleFull)
for PR 2385 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2385#discussion_r17526144
--- Diff: python/pyspark/context.py ---
@@ -99,8 +100,8 @@ def __init__(self, master=None, appName=None,
sparkHome=None, pyFiles=None,
...
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/2385#issuecomment-1894
LGTM, just one minor comment, it's not must to have.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user staple opened a pull request:
https://github.com/apache/spark/pull/2385
[SPARK-1087] Move python traceback utilities into new traceback_utils.py
file.
Also made minor cleanups to JavaStackTrace.
You can merge this pull request into a Git repository by running:
$
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2385#issuecomment-55516250
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
16 matches
Mail list logo
