[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/8956#discussion_r42304900 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -216,6 +255,9 @@ private[sql] object

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-15 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8956#discussion_r42174368 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -48,6 +48,34 @@ private[sql] object

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-15 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8956#discussion_r42177215 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala --- @@ -112,6 +112,11 @@ class

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-15 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8956#discussion_r42176731 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -164,7 +192,18 @@ private[sql] object

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-15 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8956#discussion_r42176707 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -48,6 +48,34 @@ private[sql] object

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-15 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8956#discussion_r42176719 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -48,6 +48,34 @@ private[sql] object

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-15 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8956#discussion_r42176705 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -48,6 +48,34 @@ private[sql] object

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-15 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-148533198 Off topic but related, `SetInFilter.canDrop` can also leverage statistics information: ```scala private val min = valueSet.min private val max

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-15 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8956#discussion_r42176890 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala --- @@ -112,6 +112,11 @@ class

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-15 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8956#discussion_r42176877 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -216,6 +255,9 @@ private[sql] object

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-15 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8956#discussion_r42183960 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -48,6 +48,34 @@ private[sql] object

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-15 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8956#discussion_r42177620 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala --- @@ -112,6 +112,11 @@ class

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145606676 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145606518 [Test build #43238 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43238/console) for PR 8956 at commit

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145606678 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145572774 [Test build #43238 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43238/consoleFull) for PR 8956 at commit

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145571210 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145571273 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145255619 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145255609 [Test build #43213 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43213/console) for PR 8956 at commit

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145254455 [Test build #43213 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43213/consoleFull) for PR 8956 at commit

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145255617 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145254209 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145254205 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145278883 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145278882 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145278786 [Test build #43215 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43215/console) for PR 8956 at commit

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145264246 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145264250 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145264590 [Test build #43215 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43215/consoleFull) for PR 8956 at commit

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-03 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145263979 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-03 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-145213256 cc @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-144701972 [Test build #43149 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43149/consoleFull) for PR 8956 at commit

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-144726375 [Test build #43149 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43149/console) for PR 8956 at commit

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-01 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/8956 [SPARK-10895][SQL] Push down string filters to Parquet JIRA: https://issues.apache.org/jira/browse/SPARK-10895 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-144726522 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-144726518 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-144700733 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10895][SQL] Push down string filters to...

2015-10-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8956#issuecomment-144700717 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not