Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9192
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221952267
Merging this to master and branch-2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221774354
**[Test build #59341 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59341/consoleFull)**
for PR 9192 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221774407
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221774409
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221772896
Thanks for the update. LGTM. Will merge after Jenkins passes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221772591
**[Test build #59341 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59341/consoleFull)**
for PR 9192 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221770384
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221770383
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221770380
**[Test build #59337 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59337/consoleFull)**
for PR 9192 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221770106
**[Test build #59337 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59337/consoleFull)**
for PR 9192 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221768776
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221768777
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221768774
**[Test build #59335 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59335/consoleFull)**
for PR 9192 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221768460
**[Test build #59335 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59335/consoleFull)**
for PR 9192 at commit
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r64687334
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -169,48 +169,50 @@ test_that("create DataFrame from RDD", {
error = function(err) {
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221767863
@shivaram it's true there's some scaffolding we need to add (though I'm
pretty we could codegen them on the fly instead). I think the idea is this is
temporary and
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221767615
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221767617
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221767613
**[Test build #59331 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59331/consoleFull)**
for PR 9192 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221767353
**[Test build #59331 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59331/consoleFull)**
for PR 9192 at commit
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r64686844
--- Diff: R/pkg/R/SQLContext.R ---
@@ -362,12 +433,14 @@ sql <- function(sqlContext, sqlQuery) {
#' sc <- sparkR.init()
#' sqlContext <-
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221766378
LGTM except some minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r64686315
--- Diff: R/pkg/R/SQLContext.R ---
@@ -254,6 +301,7 @@ jsonFile <- function(sqlContext, path) {
#' df <- jsonRDD(sqlContext, rdd)
#'}
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r64686229
--- Diff: R/pkg/R/jobj.R ---
@@ -77,6 +77,11 @@ print.jobj <- function(x, ...) {
cat("Java ref type", name, "id", x$id, "\n", sep = " ")
}
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r64686152
--- Diff: R/pkg/R/SQLContext.R ---
@@ -37,6 +37,37 @@ getInternalType <- function(x) {
stop(paste("Unsupported type for SparkDataFrame:",
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r64685560
--- Diff: R/pkg/R/SQLContext.R ---
@@ -362,12 +433,14 @@ sql <- function(sqlContext, sqlQuery) {
#' sc <- sparkR.init()
#' sqlContext <-
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r64685428
--- Diff: R/pkg/R/SQLContext.R ---
@@ -362,12 +433,14 @@ sql <- function(sqlContext, sqlQuery) {
#' sc <- sparkR.init()
#' sqlContext <-
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r64675714
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -169,48 +169,50 @@ test_that("create DataFrame from RDD", {
error = function(err) {
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221676892
Thanks @felixcheung for the update. I left some minor comments inline.
It seems unfortunate that we need to do some amount of code duplication to
get this to
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r64633002
--- Diff: R/pkg/R/SQLContext.R ---
@@ -37,6 +37,37 @@ getInternalType <- function(x) {
stop(paste("Unsupported type for SparkDataFrame:",
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r64633530
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -169,48 +169,50 @@ test_that("create DataFrame from RDD", {
error = function(err) {
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r64633209
--- Diff: R/pkg/R/SQLContext.R ---
@@ -254,6 +301,7 @@ jsonFile <- function(sqlContext, path) {
#' df <- jsonRDD(sqlContext, rdd)
#'}
+#
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221130256
Took me a while to rebase, and caught up with new changes.
This is WIP - I will need to check on roxygen2 doc, and look into
SparkSession
---
If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221130044
**[Test build #59164 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59164/consoleFull)**
for PR 9192 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221130085
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221130088
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221130082
**[Test build #59164 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59164/consoleFull)**
for PR 9192 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-22418
SparkSession definitely makes more sense, given DataFrame is the main API
...
---
If your project is set up for it, you can reply to this email and have your
reply
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221103064
Sorry I was busy last week and missed this -- but +1 to keeping backwards
compatibility. BTW on that note will this also change the entry point in
SparkR to be
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-220816684
I think maintaining backward compatibility would be useful. Do you have
time to bring this up to date this week so we get it in for 2.0? It's pretty
late for a change of
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-220767086
Would you like API without SQLContext (or SparkSession) parameter or, as
what is in this PR, API that can be backward compatible with or without it?
---
If your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-220490142
Actually I'd love to have this...!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-152774654
Any more thought on this and #9185 ? It looks like we are cutting the 1.6.0
release very soon, and it will be good if API changes can go into a minor
release change
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r42716848
--- Diff: R/pkg/R/SQLContext.R ---
@@ -17,6 +17,34 @@
# SQLcontext.R: SQLContext-driven functions
+#' Temporary function to reroute
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-150127311
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-150127349
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r42726488
--- Diff: R/pkg/R/SQLContext.R ---
@@ -17,6 +17,34 @@
# SQLcontext.R: SQLContext-driven functions
+#' Temporary function to reroute old
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r42726208
--- Diff: R/pkg/R/jobj.R ---
@@ -77,6 +77,11 @@ print.jobj <- function(x, ...) {
cat("Java ref type", name, "id", x$id, "\n", sep = " ")
}
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-150165422
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-150165423
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-150165301
**[Test build #44139 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44139/consoleFull)**
for PR 9192 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-150128523
**[Test build #44139 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44139/consoleFull)**
for PR 9192 at commit
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r42772732
--- Diff: R/pkg/R/SQLContext.R ---
@@ -17,6 +17,34 @@
# SQLcontext.R: SQLContext-driven functions
+#' Temporary function to reroute old
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r42711959
--- Diff: R/pkg/R/SQLContext.R ---
@@ -17,6 +17,34 @@
# SQLcontext.R: SQLContext-driven functions
+#' Temporary function to reroute old
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r42664614
--- Diff: R/pkg/R/SQLContext.R ---
@@ -17,6 +17,34 @@
# SQLcontext.R: SQLContext-driven functions
+#' Temporary function to reroute
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149990149
**[Test build #44080 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44080/consoleFull)**
for PR 9192 at commit
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r42662379
--- Diff: R/pkg/R/SQLContext.R ---
@@ -17,6 +17,34 @@
# SQLcontext.R: SQLContext-driven functions
+#' Temporary function to reroute
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r42659643
--- Diff: R/pkg/R/SQLContext.R ---
@@ -17,6 +17,34 @@
# SQLcontext.R: SQLContext-driven functions
+#' Temporary function to reroute
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r42659746
--- Diff: R/pkg/R/SQLContext.R ---
@@ -17,6 +17,34 @@
# SQLcontext.R: SQLContext-driven functions
+#' Temporary function to reroute
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149989384
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149989430
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r42711903
--- Diff: R/pkg/R/SQLContext.R ---
@@ -17,6 +17,34 @@
# SQLcontext.R: SQLContext-driven functions
+#' Temporary function to reroute old
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149995521
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149995526
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149995360
**[Test build #44080 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44080/consoleFull)**
for PR 9192 at commit
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r42601678
--- Diff: R/pkg/R/SQLContext.R ---
@@ -17,6 +17,34 @@
# SQLcontext.R: SQLContext-driven functions
+#' Temporary function to reroute old
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r42601519
--- Diff: R/pkg/R/SQLContext.R ---
@@ -17,6 +17,34 @@
# SQLcontext.R: SQLContext-driven functions
+#' Temporary function to reroute old
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r42601604
--- Diff: R/pkg/R/SQLContext.R ---
@@ -17,6 +17,34 @@
# SQLcontext.R: SQLContext-driven functions
+#' Temporary function to reroute old
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r42602160
--- Diff: R/pkg/R/SQLContext.R ---
@@ -17,6 +17,34 @@
# SQLcontext.R: SQLContext-driven functions
+#' Temporary function to reroute old
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149791993
**[Test build #44047 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44047/consoleFull)**
for PR 9192 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149793988
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149793990
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149793919
**[Test build #44047 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44047/consoleFull)**
for PR 9192 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149806170
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149806069
[Test build #44042 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44042/console)
for PR 9192 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149806172
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149791103
Rebase to master. Update to fix the new `as.DataFrame` method.
@davies Thanks! Appreciated. I'd like to leave R doc update separated if
that's ok by you -
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/9192
[SPARK-10903] [SPARKR] R - Simplify SQLContext method signatures and use a
singleton
Eliminate the need to pass sqlContext to method since it is a singleton -
and we don't want to support
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149782082
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149782827
[Test build #44042 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44042/consoleFull)
for PR 9192 at commit
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149790122
@felixcheung This looks great overall, could you also update all the
examples?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-149791268
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
83 matches
Mail list logo
