Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11613
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-196527457
Merging into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-196525513
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-196525511
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-196525119
**[Test build #53090 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53090/consoleFull)**
for PR 11613 at commit
[`319fb55`](https://g
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-196484795
LGTM once tests pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-196465836
**[Test build #53090 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53090/consoleFull)**
for PR 11613 at commit
[`319fb55`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-196455322
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-196455327
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-196455250
**[Test build #53084 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53084/consoleFull)**
for PR 11613 at commit
[`5b3810c`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-196445488
**[Test build #53084 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53084/consoleFull)**
for PR 11613 at commit
[`5b3810c`](https://gi
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-196442324
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195647101
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195647098
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195647035
**[Test build #52972 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52972/consoleFull)**
for PR 11613 at commit
[`5b3810c`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195644837
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195644838
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195644743
**[Test build #52971 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52971/consoleFull)**
for PR 11613 at commit
[`bc5c2b9`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195623518
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195623515
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195623171
**[Test build #52956 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52956/consoleFull)**
for PR 11613 at commit
[`c5a23a4`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195619862
**[Test build #52972 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52972/consoleFull)**
for PR 11613 at commit
[`5b3810c`](https://gi
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195616282
I ended up having to roll back that size estimation improvement because it
broke some tests which relied on the old behavior. I'd still like to make that
change but w
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195615909
**[Test build #52971 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52971/consoleFull)**
for PR 11613 at commit
[`bc5c2b9`](https://gi
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55908919
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55907029
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55906595
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55906584
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55906566
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -717,8 +717,13 @@ private[spark] class BlockManager(
level: Sto
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55906570
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -793,7 +798,12 @@ private[spark] class BlockManager(
// We wi
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55906575
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -520,3 +447,42 @@ private[spark] class MemoryStore(
logMemo
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195592066
**[Test build #52956 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52956/consoleFull)**
for PR 11613 at commit
[`c5a23a4`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195591625
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195591622
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55900897
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -520,3 +447,42 @@ private[spark] class MemoryStore(
logMem
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195591366
**[Test build #52942 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52942/consoleFull)**
for PR 11613 at commit
[`dbca8cf`](https://g
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55900804
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55900567
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195590566
@JoshRosen looks great. I did a close review and could not find anything
serious. My suggestions are mainly to add more comments.
---
If your project is set up for
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55900453
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -49,14 +49,6 @@ private[spark] class MemoryStore(
// A mappi
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55900156
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55899657
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55899254
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55898978
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55898848
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55898874
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55898706
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55898608
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195582619
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195582626
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55898638
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195581011
**[Test build #52941 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52941/consoleFull)**
for PR 11613 at commit
[`ebb25f9`](https://g
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55898378
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55898188
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55898084
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55897952
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55897722
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -520,3 +447,42 @@ private[spark] class MemoryStore(
logMemo
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55897743
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -520,3 +447,42 @@ private[spark] class MemoryStore(
logMemo
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55897629
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55896526
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -717,8 +717,13 @@ private[spark] class BlockManager(
level: St
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55897125
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -100,48 +92,136 @@ private[spark] class MemoryStore(
*/
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55896316
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -520,3 +447,42 @@ private[spark] class MemoryStore(
logMem
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55896680
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -793,7 +798,12 @@ private[spark] class BlockManager(
// We w
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11613#discussion_r55895725
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -520,3 +447,42 @@ private[spark] class MemoryStore(
logMem
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195571052
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195571056
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195570778
**[Test build #52935 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52935/consoleFull)**
for PR 11613 at commit
[`858aea2`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195536492
**[Test build #52942 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52942/consoleFull)**
for PR 11613 at commit
[`dbca8cf`](https://gi
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/11613#issuecomment-195534728
@andrewor14 @nongli, this should now be ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
69 matches
Mail list logo
