Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-152515643
Hm, I'm inclined to go ahead and merge this for master, though I'm also
wary of the implications. The problem seems clear, the explanation seems clear
and the change is
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-152522888
@srowen I agree. The only missing part is having the opinion of someone
who's intimate with the serializer and class loader handling inside Spark.
Let's merge this
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-152581043
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-152584781
merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9282
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-152155500
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-152155517
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-152180069
The serializer is delegating to the context class loader for instantiating
classes it receives on the wire. When this class loader is missing (`null`),
the JVM looks up
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-152156815
**[Test build #44591 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44591/consoleFull)**
for PR 9282 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-152155075
Looks like this is a regression from 1.5.1 so we should definitely fix it.
Even though this change is only one line it could change a lot of things. Can
we verify
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-152154833
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-152187108
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-152187102
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-151530146
There's no clear answer, unfortunately. The serializer has a "default class
loader" that is set explicitly only when using the REPL. In the other cases
it's done through
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-151523542
@srowen who could have a look at this one? It's a complete blocker for
Mesos, fine-grained mode is the default deployment.
---
If your project is set up for it, you can
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-151525524
Hm, I don't know much about this part. Does this mirror similar approaches
in other code? that would be good evidence that it's a good idea. How is it
handled in other
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-151530492
OK, I'm tentatively OK with merging this if it clearly fixes a problem,
doesn't cause others (at least tests pass), you both think it's the right
thing, and it resembles
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-151636017
Just curious why this suddenly becomes a problem, do you have any idea what
caused this?
---
If your project is set up for it, you can reply to this email and have
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-151636255
And also +1 to merge this to fix users problems as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-151258037
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-151257831
**[Test build #44364 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44364/consoleFull)**
for PR 9282 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-151258036
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user dragos opened a pull request:
https://github.com/apache/spark/pull/9282
[SPARK-10986][Mesos] Set the context class loader in the Mesos executor
backend.
See [SPARK-10986](https://issues.apache.org/jira/browse/SPARK-10986) for
details.
This fixes the
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-151209854
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-151209819
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-151212320
**[Test build #44364 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44364/consoleFull)**
for PR 9282 at commit
Github user kaysoky commented on the pull request:
https://github.com/apache/spark/pull/9282#issuecomment-151240433
:+1:
Tested on a local Mesos cluster (fine-grained mode).
---
If your project is set up for it, you can reply to this email and have your
reply appear on
27 matches
Mail list logo
