[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-147909701 [Test build #43698 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43698/consoleFull) for PR 9023 at commit

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-147914489 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-147909314 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-147909323 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9023 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-13 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-147909042 @shivaram, rebased to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-13 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-147939288 Thanks @sun-rui LGTM. Merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-147914487 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-147914074 [Test build #43698 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43698/console) for PR 9023 at commit

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-13 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-147784338 @sun-rui Change looks pretty good. I didn't notice the refactoring of convertListToEnvironment -- I think thats a good idea. Could you bring this up to date with

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9023#discussion_r41699681 --- Diff: R/pkg/R/stats.R --- @@ -100,3 +100,36 @@ setMethod("corr", statFunctions <- callJMethod(x@sdf, "stat")

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9023#discussion_r41704334 --- Diff: R/pkg/R/stats.R --- @@ -100,3 +100,36 @@ setMethod("corr", statFunctions <- callJMethod(x@sdf, "stat")

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-10 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9023#discussion_r41704114 --- Diff: R/pkg/R/stats.R --- @@ -100,3 +100,36 @@ setMethod("corr", statFunctions <- callJMethod(x@sdf, "stat")

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-147069854 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-147069856 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-147069823 [Test build #43522 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43522/console) for PR 9023 at commit

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-147046379 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-147046622 [Test build #43522 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43522/consoleFull) for PR 9023 at commit

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-10 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9023#discussion_r41693821 --- Diff: R/pkg/R/utils.R --- @@ -588,3 +588,13 @@ mergePartitions <- function(rdd, zip) { PipelinedRDD(rdd, partitionFunc) } + +#

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-147046382 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-09 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-147020680 The conversion from a named list to an env to be passed to JVM backend was used in several functions, so I extract it to a common util function that can be reused.

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-146783126 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-146783130 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-146782780 [Test build #43461 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43461/console) for PR 9023 at commit

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-146776937 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-146777022 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-146778937 [Test build #43461 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43461/consoleFull) for PR 9023 at commit

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9023#discussion_r41692723 --- Diff: R/pkg/R/utils.R --- @@ -588,3 +588,13 @@ mergePartitions <- function(rdd, zip) { PipelinedRDD(rdd, partitionFunc) } +

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-09 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-147030568 got it. suggest adding a check, looks good otherwise. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9023#discussion_r41692768 --- Diff: R/pkg/R/DataFrame.R --- @@ -1795,17 +1795,15 @@ setMethod("fillna", if (length(colNames) == 0 || !all(colNames != "")) {

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-09 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/9023#discussion_r41648341 --- Diff: R/pkg/R/DataFrame.R --- @@ -1795,17 +1795,15 @@ setMethod("fillna", if (length(colNames) == 0 || !all(colNames != "")) {

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9023#discussion_r41657723 --- Diff: R/pkg/R/sparkR.R --- @@ -163,19 +163,13 @@ sparkR.init <- function( sparkHome <- suppressWarnings(normalizePath(sparkHome)) }

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-08 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-146608515 cc @felixcheung --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-08 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-146741164 @felixcheung, yes, I agree. I will change fractions as a named list. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-08 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-146649139 It looked in this a bit since I thought I would be working on SPARK-9443 Would it be more R-like to support named list like this: ``` fractions =

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-146424973 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-146424986 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-07 Thread sun-rui
GitHub user sun-rui opened a pull request: https://github.com/apache/spark/pull/9023 [SPARK-10996][SPARKR] Implement sampleBy() in DataFrameStatFunctions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sun-rui/spark SPARK-10996

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-146425647 [Test build #43382 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43382/consoleFull) for PR 9023 at commit

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-146428347 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-146428350 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9023#issuecomment-146428102 [Test build #43382 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43382/console) for PR 9023 at commit