Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-171420150
cc @marmbrus too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-171395396
@cloud-fan Should we revisit it later?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-171396586
I think this simplfication can be useful, e.g.
https://github.com/apache/spark/pull/10630
Do we agree on this approach? If we do, I can update it soon.
---
If
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-171487491
My concern with this is that no-op operators are going to act as blockers
when looking for patterns in the query plan. So thinking about it more I'm not
sure this is
Github user cloud-fan closed the pull request at:
https://github.com/apache/spark/pull/9081
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-171489840
makes sense, changing output of leaf node looks easier to reason about,
closing.
---
If your project is set up for it, you can reply to this email and have your
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-157440817
@cloud-fan I am wondering if this will be merged soon?
I am not sure if I should fix a couple of self join issues before your
merge. Or I should not waste
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-157474071
This seems like a good idea, but I'd propose we delay refactoring until
after the 1.6 release.
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148546024
[Test build #43809 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43809/console)
for PR 9081 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148546209
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148546208
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148518894
[Test build #43809 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43809/consoleFull)
for PR 9081 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148517973
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148517954
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148486747
hi @marmbrus , checked with @yhuai , `OutputFaker` is no longer used, so I
removed it.
---
If your project is set up for it, you can reply to this email and have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148487002
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148486981
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148488344
[Test build #43803 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43803/consoleFull)
for PR 9081 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148496474
[Test build #43803 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43803/console)
for PR 9081 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148496546
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148496543
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148205806
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148205770
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148206777
Two more things:
- `OutputFaker`, I think thats doing the same thing? Do we need both? Is
output faker even used anymore?
- Should we update
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148208323
[Test build #43742 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43742/consoleFull)
for PR 9081 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148233674
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148233671
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-148233570
[Test build #43742 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43742/console)
for PR 9081 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147636275
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147636242
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147639157
[Test build #43635 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43635/consoleFull)
for PR 9081 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147647068
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147647067
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147647003
[Test build #43635 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43635/console)
for PR 9081 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147810111
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147809772
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147797711
[Test build #43653 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43653/consoleFull)
for PR 9081 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147801425
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147801423
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147801383
[Test build #43653 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43653/console)
for PR 9081 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147810148
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147813225
[Test build #43658 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43658/consoleFull)
for PR 9081 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147795939
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147795907
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147853396
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9081#discussion_r41930462
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/MultiInstanceRelation.scala
---
@@ -1,33 +0,0 @@
-/*
- * Licensed to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147853049
[Test build #43658 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43658/console)
for PR 9081 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147853397
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147857302
cc @marmbrus @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9081#discussion_r41930249
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -28,6 +28,17 @@ import org.apache.spark.util.MutablePair
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9081#discussion_r41930272
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -23,6 +23,25 @@ import
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147535313
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147535338
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/9081
[SPARK-11072][SQL] simplify self join handling
https://issues.apache.org/jira/browse/SPARK-11072
You can merge this pull request into a Git repository by running:
$ git pull
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147552338
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147552341
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147552273
[Test build #43591 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43591/console)
for PR 9081 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9081#issuecomment-147535882
[Test build #43591 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43591/consoleFull)
for PR 9081 at commit
58 matches
Mail list logo
