Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-151396799
Thanks! On `@Experimental`, I assume it simply means that it is intended
for end users (i.e. not a `@DeveloperApi`) but may be removed or changed at any
time (without
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-151727181
@srowen Thanks for sharing your view! I agree that most users won't pay
attention to the tags. It would be a surprise to users if we make break changes
on
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-150834895
@mengxr let me know if this is OK with you. I made the updates you
suggested.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-150621704
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-150622726
**[Test build #44228 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44228/consoleFull)**
for PR 9169 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-150621772
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-150632554
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-150632553
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-150632406
**[Test build #44228 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44228/consoleFull)**
for PR 9169 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-149798156
**[Test build #44049 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44049/consoleFull)**
for PR 9169 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-149798259
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-149798260
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-149792274
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-149792262
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-149792624
**[Test build #44049 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44049/consoleFull)**
for PR 9169 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-149791995
All done, thank you. Yes I think there's a good reason MLlib has more
`@Experimental`, also simply because it makes use of this feature a lot. ML
pipelines is still
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-149473946
To give you an idea of how prevalent the `@Experimental` tag is ...
- Streaming: 6
- Core: 29
- SQL: 42
- ML: 93
- MLlib: 95
Worth
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9169#discussion_r42536477
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/pmml/PMMLExportable.scala ---
@@ -45,20 +45,16 @@ trait PMMLExportable {
}
/**
-
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9169#discussion_r42536214
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala ---
@@ -103,21 +103,17 @@ class KMeans private (
}
/**
-
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9169#discussion_r42536743
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Algo.scala ---
@@ -17,14 +17,12 @@
package
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9169#discussion_r42536817
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Entropy.scala ---
@@ -17,15 +17,13 @@
package
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/9169
[SPARK-11184] [MLLIB] Declare most of .mllib code not-Experimental
Remove "Experimental" from .mllib code that has been around since 1.4.0 or
earlier
You can merge this pull request into a Git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-149352304
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-149352285
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-149354507
**[Test build #43937 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43937/consoleFull)**
for PR 9169 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-149363564
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-149363441
**[Test build #43937 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43937/consoleFull)**
for PR 9169 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9169#issuecomment-149363562
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
28 matches
Mail list logo
