[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-26 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-151055969 @shivaram, [R lag function](https://stat.ethz.ch/R-manual/R-devel/library/stats/html/lag.html) is for time series objects, which is irrelevant to the lead/lag here in

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-26 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-151350204 Yes. the lag will be masked. Just as discussed before, sometimes, this is allowed, as I assume lag is not so commonly and frequently used ("dplyr" masks lag also).

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-26 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-151375443 @shivaram, for your suggestion that "we should a make a list of functions that we mask and are incompatible", I submitted

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-26 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-151366290 Hmm I see. In the case of `lag` I can see your point. But at a high level I think we should a make a list of functions that we mask and are incompatible (i.e. things

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-26 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-151195921 Ok. The thing I was worried about is that if somebody loads SparkR they won't be able to use `lag` from stats -- Can you check if that is the case ? --- If your

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-23 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/9193#discussion_r42886920 --- Diff: R/pkg/R/functions.R --- @@ -2008,3 +2008,101 @@ setMethod("ifelse", "otherwise", no)

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-150124146 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-150124071 **[Test build #44128 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44128/consoleFull)** for PR 9193 at commit

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-150124147 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-150105205 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-150105217 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-150105522 **[Test build #44128 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44128/consoleFull)** for PR 9193 at commit

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-150105010 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149844454 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149844384 **[Test build #44051 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44051/consoleFull)** for PR 9193 at commit

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149844457 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9193#discussion_r42587435 --- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala --- @@ -224,7 +224,8 @@ private[r] class RBackendHandler(server: RBackend)

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149793886 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149793899 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149795220 **[Test build #44050 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44050/consoleFull)** for PR 9193 at commit

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9193#discussion_r42595273 --- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala --- @@ -224,7 +224,8 @@ private[r] class RBackendHandler(server: RBackend)

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149813584 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149813507 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149815360 **[Test build #44051 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44051/consoleFull)** for PR 9193 at commit

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149815518 **[Test build #44050 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44050/consoleFull)** for PR 9193 at commit

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149815640 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149815642 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-20 Thread sun-rui
GitHub user sun-rui opened a pull request: https://github.com/apache/spark/pull/9193 [SPARK-11209][SPARKR] Add window functions into SparkR [step 1]. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sun-rui/spark SPARK-11209

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149784768 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149784764 **[Test build #44043 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44043/consoleFull)** for PR 9193 at commit

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149784767 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149783538 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149783525 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-149784461 **[Test build #44043 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44043/consoleFull)** for PR 9193 at commit