Github user JoshRosen closed the pull request at:
https://github.com/apache/spark/pull/9427
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-164855721
@JoshRosen It should be something wrong in this PR, if we can't fix it
easily, would you mind close this one?
---
If your project is set up for it, you can reply to
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-164857620
Yeah, I'm going to close this for now; I don't think that this is a
high-priority issue to fix for 1.5.x since it's been around forever and nobody
reported problems
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-164621356
**[Test build #47686 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47686/console)**
for PR 9427 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-164621456
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-164621455
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-164590667
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-164591703
[Test build #47686 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47686/consoleFull)
for PR 9427 at commit
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-162945020
tes this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-162948361
[Test build #47344 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47344/consoleFull)
for PR 9427 at commit
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-162945042
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-163000330
**[Test build #47344 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47344/console)**
for PR 9427 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-163000436
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-163000439
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-161375635
[Test build #2150 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2150/consoleFull)
for PR 9427 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-161425534
**[Test build #2150 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2150/console)**
for PR 9427 at commit
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-161455225
@JoshRosen Is there something wrong with this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-161474418
Looks like it timed out while compiling? Let me try again.
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-159706431
[Test build #2115 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2115/consoleFull)
for PR 9427 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-159744043
**[Test build #2115 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2115/console)**
for PR 9427 at commit
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-159451714
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-159453734
[Test build #46648 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46648/consoleFull)
for PR 9427 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-159486153
**[Test build #46648 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46648/console)**
for PR 9427 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-159486180
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-159486181
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9427#discussion_r45650551
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala ---
@@ -89,9 +89,15 @@ private[spark] abstract class Task[T](
} finally {
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-159091597
@davies, I've updated this to address your comment; PTAL.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-159094315
[Test build #46559 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46559/consoleFull)
for PR 9427 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-159128094
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-159128095
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-159128006
**[Test build #46559 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46559/console)**
for PR 9427 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9427#discussion_r43926412
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala ---
@@ -89,9 +89,15 @@ private[spark] abstract class Task[T](
} finally {
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-153839214
LGTM, except one minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-153285115
Hmm, looks like legitimate test failures. I'll investigate tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-153198660
Ping @yhuai, any objection to merging this to 1.5? A similar fix has
already been incorporated into master as part of my memory manager
consolidation patch. We could
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-153202532
Is it risky? Looks not?
If it is safe patch, wow about we add the check in `Task.scala` first to
make sure that 1.5 does throw the exception? Then, we add the fix
Github user JoshRosen closed the pull request at:
https://github.com/apache/spark/pull/9260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-153208863
[Test build #44858 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44858/consoleFull)
for PR 9427 at commit
GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/9427
[SPARK-11293] Fix shuffle memory leaks in Spillable collections and
UnsafeShuffleWriter (branch-1.5)
This patch fixes multiple memory leaks in `Spillable` collections, as well
as a leak in
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-153207783
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-153207799
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-153207836
@yhuai I think it's pretty low-risk. I'm going to close this PR and will
continue work over at #9427, which is opened against branch-1.5.
---
If your project is set
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-153210196
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-153210174
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-153210300
[Test build #44859 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44859/consoleFull)
for PR 9427 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-153233887
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-153233886
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-153233869
**[Test build #44858 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44858/console)**
for PR 9427 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9427#issuecomment-153234731
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9260#discussion_r42951514
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala ---
@@ -89,9 +89,15 @@ private[spark] abstract class Task[T](
} finally {
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150980972
Looks good to me. Probably ask someone who is more familiar with this part
of the code for the final sign-off.
---
If your project is set up for it, you can reply to
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9260#discussion_r42952509
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala ---
@@ -89,9 +89,15 @@ private[spark] abstract class Task[T](
} finally {
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-151020960
I've gone ahead and merged #9127, which contains something similar to these
changes, but updated to reflect the memory manager unification. I still think
that we
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150771923
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150778312
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150778291
**[Test build #44291 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44291/consoleFull)**
for PR 9260 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150772252
**[Test build #44291 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44291/consoleFull)**
for PR 9260 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150771851
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150771836
**[Test build #44288 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44288/consoleFull)**
for PR 9260 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150771852
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150778313
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150772014
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150772011
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150757380
**[Test build #44288 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44288/consoleFull)**
for PR 9260 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150756996
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150748082
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150748081
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150748065
**[Test build #44281 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44281/consoleFull)**
for PR 9260 at commit
GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/9260
[SPARK-11293] Fix shuffle memory leaks in Spillable collections and
UnsafeShuffleWriter
This patch fixes multiple memory leaks in `Spillable` collections, as well
as a leak in
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150736377
/cc @andrewor14 @rxin @davies @mateiz
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150736477
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150736484
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9260#issuecomment-150736613
**[Test build #44281 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44281/consoleFull)**
for PR 9260 at commit
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9260#discussion_r42928573
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
---
@@ -214,13 +215,18 @@ class ExternalAppendOnlyMap[K, V, C](
74 matches
Mail list logo
