Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-155246650
@reggert I've closed your issue as a duplicate. Can you remove it from the
title and use only `SPARK-9026` to avoid potential confusion?
---
If your project is set u
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r44356014
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Utils.scala
---
@@ -1,393 +0,0 @@
-/*
- * Licensed to th
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-155158072
**[Test build #45395 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45395/consoleFull)**
for PR 9264 at commit
[`93b3065`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-155158077
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-155157119
**[Test build #45395 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45395/consoleFull)**
for PR 9264 at commit
[`93b3065`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-155156752
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-155156691
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-155155616
Jenkins, ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-155155597
Hi @reggert , I'm not the best person to review this, so I can't definitely
say what needs to be done to get it merged. I pointed out a few minor style
issues just to ke
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r44314355
--- Diff:
core/src/test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala ---
@@ -197,4 +197,30 @@ class AsyncRDDActionsSuite extends SparkFunSuite with
B
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r44313694
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -22,7 +22,10 @@ import java.util.Properties
import java.util.concurrent
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r44313673
--- Diff: core/src/main/scala/org/apache/spark/rdd/AsyncRDDActions.scala ---
@@ -22,10 +22,10 @@ import java.util.concurrent.atomic.AtomicLong
import org.a
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r44313583
--- Diff: core/src/main/scala/org/apache/spark/FutureAction.scala ---
@@ -22,11 +22,11 @@ import java.util.concurrent.TimeUnit
import org.apache.spar
Github user reggert commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-154877812
What else needs to be done to get this PR merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user reggert commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-154751770
I've added some unit tests that verify that my changes, do, indeed, stop
callbacks from consuming threads before the jobs have completed.
---
If your project is set up
15 matches
Mail list logo
