Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-162031306
I'll add an exclusion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-161861637
It looks like some MiMa tests are now failing in the Hadoop pre-YARN builds:
```
[info] spark-core: found 1 potential binary incompatibilities (filtered
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-161740895
Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r46434094
--- Diff:
yarn/src/test/scala/org/apache/spark/scheduler/cluster/ExtensionServiceIntegrationSuite.scala
---
@@ -0,0 +1,87 @@
+/*
+ * Licensed
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r46432466
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -51,6 +51,64 @@ private[spark] abstract class
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r46432648
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -51,6 +51,64 @@ private[spark] abstract class
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r46433390
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-16135
**[Test build #47072 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47072/consoleFull)**
for PR 9182 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-161428493
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-161428373
**[Test build #47072 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47072/consoleFull)**
for PR 9182 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-161428496
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-161460950
**[Test build #47084 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47084/consoleFull)**
for PR 9182 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-161461070
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-161433043
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-161461069
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-161434959
**[Test build #47084 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47084/consoleFull)**
for PR 9182 at commit
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-161445985
LGTM pending tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r46336258
--- Diff:
yarn/src/test/scala/org/apache/spark/scheduler/cluster/ExtensionServiceIntegrationSuite.scala
---
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-161090381
A few minor things left, otherwise looks ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r46335614
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -51,6 +51,64 @@ private[spark] abstract class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r46335588
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -51,6 +51,64 @@ private[spark] abstract class
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-161107529
thanks -will deal with these on wednesday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r46335932
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-160676105
**[Test build #46892 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46892/consoleFull)**
for PR 9182 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-160675906
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-160670545
(catching up: looks like the git tool I'm using decided to make up a new
remote branch when I renamed the local. Fixing to track the old one and pushing
up again)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-160675904
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-160712732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-160712406
**[Test build #46892 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46892/consoleFull)**
for PR 9182 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-160712729
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-158249750
@steveloughran I think you forgot to upload the new code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r45225663
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r45226057
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r45226337
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r45226729
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r45226180
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-157813169
OK, this is what I've done
1. AM doesn't propagate app/attempt IDs via system properties. It still
sets them for other things to use, including
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-157814298
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-157698220
will do...ignore the latest push as its a just a rebase of the existing
work prior to any other edits
---
If your project is set up for it, you can reply to this
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r44825346
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r44824859
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r44824670
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r44824618
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-156540005
@steveloughran could you take a look at my previous suggestion? With your
current patch there are two ways that the application / attempt ID are
propagated to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r44824570
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-155968446
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-155932349
**[Test build #45681 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45681/consoleFull)**
for PR 9182 at commit
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-155937044
This just rolls back to the explicit app/attempt ID. it's got better
guarantees of what's coming down
---
If your project is set up for it, you can reply to this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-155931357
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-155931377
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152816395
and I've already gone and moved to strings. never mind.
the existing attempt IDs are nice for humans in the web UI, and potentially
in the rest, but don't
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152870622
BTW, if you're keeping `bindToYarn` and friends, you could change
`applicationId` and `applicationAttemptId` to return the values you're setting
there, which also means
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152864501
> now, should I stay with String or roll back?
Up to you. I was hoping you did not need to use the full attempt id and
instead be able to get rid of the code
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152781453
So my whole feedback about the IDs wasn't because of the type, it was
because if you could use the existing values, you wouldn't need to add all the
code related to
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43479330
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -51,6 +51,41 @@ private[spark] abstract class
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43498840
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -51,6 +51,41 @@ private[spark] abstract class
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152536617
OK, new patch with uses String values for appId and app attempt ID in the
service extension binding âbut explicitly derives these from the YARN app &
attempt
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43498798
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -51,6 +51,41 @@ private[spark] abstract class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152532383
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152532420
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152535453
**[Test build #44682 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44682/consoleFull)**
for PR 9182 at commit
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43504882
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -17,17 +17,17 @@
package
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152559610
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152559523
**[Test build #44682 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44682/consoleFull)**
for PR 9182 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152559608
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43377401
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152164064
**[Test build #44593 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44593/consoleFull)**
for PR 9182 at commit
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43374435
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -17,17 +17,17 @@
package
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43373740
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152162385
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152162358
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152188739
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43378157
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -51,6 +51,41 @@ private[spark] abstract class
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43376459
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -51,6 +51,41 @@ private[spark] abstract class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152164469
**[Test build #44593 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44593/consoleFull)**
for PR 9182 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152164476
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152164473
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-152188763
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43439082
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -51,6 +51,41 @@ private[spark] abstract class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43359713
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -51,6 +51,41 @@ private[spark] abstract class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43358778
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43363947
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -51,6 +51,41 @@ private[spark] abstract class
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43468563
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -17,17 +17,17 @@
package
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43246322
--- Diff:
yarn/src/test/scala/org/apache/spark/scheduler/cluster/SimpleExtensionService.scala
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43246273
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -51,6 +51,38 @@ private[spark] abstract class
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43246543
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-151827066
**[Test build #44524 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44524/consoleFull)**
for PR 9182 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43252081
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43253567
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43254205
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -51,6 +51,38 @@ private[spark] abstract class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43254282
--- Diff:
yarn/src/test/scala/org/apache/spark/scheduler/cluster/ExtensionServiceIntegrationSuite.scala
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43246410
--- Diff:
yarn/src/test/scala/org/apache/spark/scheduler/cluster/StubApplicationAttemptId.scala
---
@@ -0,0 +1,50 @@
+/*
--- End diff --
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43244486
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43252317
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43253907
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -51,6 +51,38 @@ private[spark] abstract class
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-151845427
Looks OK to me, mostly just style nits. Also, needs a rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43251937
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43252433
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala
---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43254504
--- Diff:
yarn/src/test/scala/org/apache/spark/scheduler/cluster/StubApplicationAttemptId.scala
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
1 - 100 of 138 matches
Mail list logo
