[GitHub] spark pull request: [SPARK-11343] [ML] Allow float and double pred...

2015-11-04 Thread dahlem
Github user dahlem commented on the pull request: https://github.com/apache/spark/pull/9296#issuecomment-153864055 No problem. Do you want me to do it against the same ticket? On Tue, Nov 3, 2015 at 12:15 AM, Xiangrui Meng wrote: >

[GitHub] spark pull request: [SPARK-11343] [ML] Allow float and double pred...

2015-11-02 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9296#issuecomment-153201122 Merged into master. @dahlem Could you send a new PR to address @felixcheung 's comment? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-11343] [ML] Allow float and double pred...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9296 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11343] [ML] Allow float and double pred...

2015-10-27 Thread dahlem
GitHub user dahlem opened a pull request: https://github.com/apache/spark/pull/9296 [SPARK-11343] [ML] Allow float and double prediction/label columns in RegressionEvaluator @mengxr, @felixcheung This pull request just relaxes the type of the prediction/label columns to

[GitHub] spark pull request: [SPARK-11343] [ML] Allow float and double pred...

2015-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9296#issuecomment-151420685 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11343] [ML] Allow float and double pred...

2015-10-27 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9296#issuecomment-151640217 LGTM pending Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11343] [ML] Allow float and double pred...

2015-10-27 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9296#issuecomment-151640187 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-11343] [ML] Allow float and double pred...

2015-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9296#issuecomment-151641260 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11343] [ML] Allow float and double pred...

2015-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9296#issuecomment-151641290 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11343] [ML] Allow float and double pred...

2015-10-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9296#discussion_r43195310 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/RegressionEvaluator.scala --- @@ -72,10 +73,13 @@ final class RegressionEvaluator

[GitHub] spark pull request: [SPARK-11343] [ML] Allow float and double pred...

2015-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9296#issuecomment-151655450 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11343] [ML] Allow float and double pred...

2015-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9296#issuecomment-151655451 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11343] [ML] Allow float and double pred...

2015-10-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9296#issuecomment-151644014 **[Test build #44464 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44464/consoleFull)** for PR 9296 at commit

[GitHub] spark pull request: [SPARK-11343] [ML] Allow float and double pred...

2015-10-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9296#issuecomment-151655274 **[Test build #44464 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44464/consoleFull)** for PR 9296 at commit