Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-153784600
Merged into master. Thanks! @yinxusen Please use `LGTM` to sign off so
there is a green box associated with this PR on
https://spark-prs.appspot.com/#mllib.
---
If
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9340
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-153339792
@mengxr @yinxusen Can we merge this, if there aren't any further issues?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152177498
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152177512
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152179766
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152179768
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152179761
**[Test build #44597 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44597/consoleFull)**
for PR 9340 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152181074
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152176928
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152179279
**[Test build #44597 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44597/consoleFull)**
for PR 9340 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152181139
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152220068
@yinxusen Let's make this PR simple. Just move the example code from user
guide to `examples`. We can have a follow-up PR to merge it with existing
example app code.
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152211342
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152228923
@mengxr Ran the style checks locally, passed. Also I have moved FPGrowth
example code from user guide to examples.
---
If your project is set up for it, you can
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152219767
@pravingadakh You can run `dev/lint-scala` and `dev/lint-python` to check
code style locally.
---
If your project is set up for it, you can reply to this email and have
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9340#discussion_r43424714
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/SimpleFPGrowth.scala ---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152291720
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152280155
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152280087
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152281564
@mengxr Everything is OK except for some style problems. @pravingadakh
Thanks for working on this.
---
If your project is set up for it, you can reply to this email
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9340#discussion_r43427001
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaPrefixSpanExample.java
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152283852
**[Test build #44621 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44621/consoleFull)**
for PR 9340 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152291569
**[Test build #44622 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44622/consoleFull)**
for PR 9340 at commit
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152292812
@yinxusen Done with all import re-orderings. You can assign me
https://issues.apache.org/jira/browse/SPARK-11382 jira if no one is working on
it.
---
If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152284385
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152284358
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152286621
**[Test build #44622 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44622/consoleFull)**
for PR 9340 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152288432
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152288292
**[Test build #44621 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44621/consoleFull)**
for PR 9340 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152288435
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152291719
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9340#discussion_r43352214
--- Diff: examples/src/main/python/mllib/fpgrowth_example.py ---
@@ -0,0 +1,28 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152092145
**[Test build #44571 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44571/consoleFull)**
for PR 9340 at commit
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9340#discussion_r43352105
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaAssociationRulesExample.java
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152087569
@pravingadakh You need to label `$example on$` and `$example off$` in
comments of example codes. Otherwise, the include_example cannot trim the code
snippt out.
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9340#discussion_r43352124
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaPrefixSpanExample.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152090442
@yinxusen I will do the changes mentioned. I am confused about one thing
though, FPGrowth examples are already available in scala and java language, and
it's
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152092324
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152092320
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152092666
@pravingadakh I perfer to use the existing example code. @mengxr What is
your opinion?
---
If your project is set up for it, you can reply to this email and have your
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152118502
@yinxusen When you say use the existing example code, you mean the one in
the doc or the one which is readily available in examples directory?
---
If your project
42 matches
Mail list logo
