Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9353
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43474244
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaNaiveBayesExample.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43474236
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaIsotonicRegressionExample.java
---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43474257
--- Diff: examples/src/main/python/mllib/naive_bayes_example.py ---
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43474262
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/IsotonicRegressionExample.scala
---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43474241
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaIsotonicRegressionExample.java
---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43474260
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/IsotonicRegressionExample.scala
---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43474263
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/IsotonicRegressionExample.scala
---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43474242
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaIsotonicRegressionExample.java
---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43474253
--- Diff: examples/src/main/python/mllib/isotonic_regression_example.py ---
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43474240
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaIsotonicRegressionExample.java
---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43474245
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaNaiveBayesExample.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43474248
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaNaiveBayesExample.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43474266
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/NaiveBayesExample.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152446497
**[Test build #44668 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44668/consoleFull)**
for PR 9353 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152449251
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152449148
**[Test build #44668 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44668/consoleFull)**
for PR 9353 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152449252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152446187
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152446165
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rishabhbhardwaj commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152450116
@mengxr Thanks for your comments and patience.I have made the required
changes.
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152157846
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user rishabhbhardwaj opened a pull request:
https://github.com/apache/spark/pull/9353
[SPARK-11383][Docs] Replaced example code in mllib using include_example
I have made the required changes in
mllib-naive-bayes.md/mllib-isotonic-regression.md and also verified them.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152221317
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152220920
@rishabhbhardwaj Thanks for working on this! I saw some code style issues
in your code. You might want to check the Spark Code Style guide first at
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152223812
**[Test build #44607 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44607/consoleFull)**
for PR 9353 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152224927
**[Test build #44607 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44607/consoleFull)**
for PR 9353 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152224935
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152220327
@yinxusen Could you help review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152221343
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152220257
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43402445
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaIsotonicRegressionExample.java
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43402461
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaIsotonicRegressionExample.java
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152224936
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user rishabhbhardwaj commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152265104
@mengxr Thanks for your comments.I have corrected the code style issues and
locally ran the style checks and they passed.
---
If your project is set up for it,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152268444
**[Test build #44617 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44617/consoleFull)**
for PR 9353 at commit
Github user rishabhbhardwaj commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152265717
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152275332
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152283464
@rishabhbhardwaj Please update the title with more specific infomation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43428253
--- Diff: examples/src/main/python/mllib/naive_bayes_example.py ---
@@ -0,0 +1,59 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43428265
--- Diff: examples/src/main/python/mllib/naive_bayes_example.py ---
@@ -0,0 +1,59 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152289516
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152289509
**[Test build #44623 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44623/consoleFull)**
for PR 9353 at commit
Github user rishabhbhardwaj commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152298344
@yinxusen Thanks for your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152275336
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152275089
**[Test build #44617 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44617/consoleFull)**
for PR 9353 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152286826
**[Test build #44620 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44620/consoleFull)**
for PR 9353 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152286856
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152289519
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152297965
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152297967
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152280156
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152280072
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152280828
**[Test build #44620 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44620/consoleFull)**
for PR 9353 at commit
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43428014
--- Diff: examples/src/main/python/mllib/isotonic_regression_example.py ---
@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43428136
--- Diff: examples/src/main/python/mllib/naive_bayes_example.py ---
@@ -0,0 +1,59 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43428863
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaIsotonicRegressionExample.java
---
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152286828
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152286993
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152286989
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152297790
**[Test build #44628 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44628/consoleFull)**
for PR 9353 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152287909
**[Test build #44623 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44623/consoleFull)**
for PR 9353 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152290855
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152290827
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152292950
**[Test build #44628 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44628/consoleFull)**
for PR 9353 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152266167
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152266138
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43463517
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaNaiveBayesExample.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43463456
--- Diff: docs/mllib-isotonic-regression.md ---
@@ -173,32 +83,7 @@ labels and real labels in the test set.
Refer to the [`IsotonicRegression`
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43463474
--- Diff: docs/mllib-naive-bayes.md ---
@@ -124,33 +70,7 @@ Note that the Python API does not yet support model
save/load but will in the fu
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9353#discussion_r43463534
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/IsotonicRegressionExample.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152372599
@mengxr This pr LGTM, except for some blank lines.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152378606
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152378558
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152379512
**[Test build #44653 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44653/consoleFull)**
for PR 9353 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152388583
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152388249
**[Test build #44653 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44653/consoleFull)**
for PR 9353 at commit
Github user rishabhbhardwaj commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152390706
@yinxusen I have removed the empty lines.Thanks for the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9353#issuecomment-152388587
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
79 matches
Mail list logo
