[GitHub] spark pull request: [SPARK-11403] Log something when killing execu...

2015-11-03 Thread darabos
Github user darabos commented on the pull request: https://github.com/apache/spark/pull/9355#issuecomment-153429008 I've done an artificial test with Spark 1.5.1 and got the `# -XX:OnOutOfMemoryError="kill %p"` message on stderr. Maybe I just missed this originally, or in fact

[GitHub] spark pull request: [SPARK-11403] Log something when killing execu...

2015-11-03 Thread darabos
Github user darabos closed the pull request at: https://github.com/apache/spark/pull/9355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11403] Log something when killing execu...

2015-11-03 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9355#issuecomment-153429423 OK np thanks for checking that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11403] Log something when killing execu...

2015-11-03 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9355#issuecomment-153411609 I suppose I'd move to close this PR unless we know it's adding something? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-11403] Log something when killing execu...

2015-11-03 Thread darabos
Github user darabos commented on the pull request: https://github.com/apache/spark/pull/9355#issuecomment-153413263 Sorry, I kept putting off experimenting with this, but I'll do it now. I'm pretty sure I checked both stdout and stderr from the executor, but not 100%. --- If your

[GitHub] spark pull request: [SPARK-11403] Log something when killing execu...

2015-10-30 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9355#issuecomment-152657452 @darabos do you think it's just that the output you're looking for is going to stderr? if so then I think this isn't necessary. Otherwise it's OK to merge --- If your

[GitHub] spark pull request: [SPARK-11403] Log something when killing execu...

2015-10-29 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9355#discussion_r43390028 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -238,7 +238,7 @@ object YarnSparkHadoopUtil { if

[GitHub] spark pull request: [SPARK-11403] Log something when killing execu...

2015-10-29 Thread darabos
Github user darabos commented on a diff in the pull request: https://github.com/apache/spark/pull/9355#discussion_r43393025 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -238,7 +238,7 @@ object YarnSparkHadoopUtil { if

[GitHub] spark pull request: [SPARK-11403] Log something when killing execu...

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9355#issuecomment-152196306 **[Test build #44602 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44602/consoleFull)** for PR 9355 at commit

[GitHub] spark pull request: [SPARK-11403] Log something when killing execu...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9355#issuecomment-152202681 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11403] Log something when killing execu...

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9355#issuecomment-152202530 **[Test build #44602 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44602/consoleFull)** for PR 9355 at commit

[GitHub] spark pull request: [SPARK-11403] Log something when killing execu...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9355#issuecomment-152202678 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11403] Log something when killing execu...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9355#issuecomment-152194084 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11403] Log something when killing execu...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9355#issuecomment-152194014 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11403] Log something when killing execu...

2015-10-29 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9355#discussion_r43428179 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -238,7 +238,7 @@ object YarnSparkHadoopUtil { if

[GitHub] spark pull request: [SPARK-11403] Log something when killing execu...

2015-10-29 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9355#discussion_r43428106 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -238,7 +238,7 @@ object YarnSparkHadoopUtil { if