Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/9405#issuecomment-159765746
Yeah, since there's not much gain and may even introduce regression in some
cases. Lets close it. Thanks all the same!
---
If your project is set up for it, you can
Github user viirya closed the pull request at:
https://github.com/apache/spark/pull/9405
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/9405#issuecomment-159593186
@liancheng your suggestion? Close it first? I think this will not introduce
much performance gain but only to reduce memory pressure on driver side for the
case with too
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/9405#issuecomment-159582457
Hey @viirya, are you still working on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/9405#discussion_r44523864
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRelation.scala
---
@@ -208,7 +208,15 @@ private[sql] class
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/9405#discussion_r44518421
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRelation.scala
---
@@ -208,7 +208,15 @@ private[sql] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/9405#discussion_r44540898
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
@@ -434,10 +439,7 @@ abstract class HadoopFsRelation
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/9405#discussion_r44537925
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
@@ -434,10 +439,7 @@ abstract class HadoopFsRelation
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/9405#discussion_r44616082
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRelation.scala
---
@@ -208,7 +208,15 @@ private[sql] class
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/9405#issuecomment-155980285
Hey @viirya, as mentioned in my inline comments, I have two major concerns
about this change:
1. It may introduce performance regression, i.e., in some cases
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/9405#discussion_r44615994
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
@@ -434,10 +439,7 @@ abstract class HadoopFsRelation
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/9405#issuecomment-154267694
cc @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9405#issuecomment-153017266
**[Test build #44805 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44805/consoleFull)**
for PR 9405 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9405#issuecomment-153017384
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9405#issuecomment-153017380
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/9405
[SPARK-11448][SQL] Skip caching part-files in driver side when configured
to merge schema and respect summaries
JIRA: https://issues.apache.org/jira/browse/SPARK-11448
We now cache
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9405#issuecomment-152952078
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9405#issuecomment-152952059
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9405#issuecomment-152955097
**[Test build #44802 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44802/consoleFull)**
for PR 9405 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9405#issuecomment-152962349
**[Test build #44802 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44802/consoleFull)**
for PR 9405 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9405#issuecomment-152962385
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9405#issuecomment-152962386
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9405#issuecomment-152992609
**[Test build #44805 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44805/consoleFull)**
for PR 9405 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9405#issuecomment-152990305
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9405#issuecomment-152990331
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
25 matches
Mail list logo
