[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155516128 Yeah in that case lets add aliases for `sd` and `var` as well and match the population/sample behavior. @felixcheung I think similar functions like `mean`

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9489#discussion_r44482198 --- Diff: R/pkg/R/functions.R --- @@ -974,6 +1006,54 @@ setMethod("soundex", column(jc) }) +#' stddev +#'

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9489#discussion_r44482223 --- Diff: R/pkg/R/functions.R --- @@ -1168,6 +1248,54 @@ setMethod("upper", column(jc) }) +#' variance +#'

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9489#discussion_r44383124 --- Diff: R/pkg/NAMESPACE --- @@ -228,6 +233,9 @@ exportMethods("%in%", "unhex", "unix_timestamp",

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9489#discussion_r44383102 --- Diff: R/pkg/NAMESPACE --- @@ -209,7 +210,11 @@ exportMethods("%in%", "sin", "sinh", "size", +

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9489#discussion_r4438 --- Diff: R/pkg/inst/tests/test_sparkSQL.R --- @@ -997,20 +1004,42 @@ test_that("group by", { expect_is(df_summarized, "DataFrame")

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9489#discussion_r44383281 --- Diff: R/pkg/R/functions.R --- @@ -1168,6 +1248,54 @@ setMethod("upper", column(jc) }) +#' variance +#'

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155362135 @shivaram, I looked at dplyr package, there is no "sd", "var" defined in the package, seems the page is referencing "sd" "var" in R base. Yes, stddev/variance

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9489#discussion_r44383218 --- Diff: R/pkg/R/functions.R --- @@ -974,6 +1006,54 @@ setMethod("soundex", column(jc) }) +#' stddev +#'

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155632388 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155633360 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155643433 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155643453 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155632410 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155633355 **[Test build #45581 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45581/consoleFull)** for PR 9489 at commit

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-15565 **[Test build #45581 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45581/consoleFull)** for PR 9489 at commit

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155633357 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155643803 **[Test build #45585 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45585/consoleFull)** for PR 9489 at commit

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155681439 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155683568 Merging this into master and 1.6 branch, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9489 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155649089 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155649088 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155649010 **[Test build #45585 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45585/consoleFull)** for PR 9489 at commit

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-09 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155154971 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-09 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155148903 cc @sun-rui --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-09 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155229852 Should we add aliases `var` and `sd` in SparkR, which are more familiar to R users? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-09 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-155244366 @mengxr possibly.. though there are usage difference with SparkR DataFrame/Column as compared to R data.frame (eg. `agg` vs

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-153987317 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-153987351 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-153988698 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-153988731 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-153991209 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-153991207 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-153991118 **[Test build #45109 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45109/consoleFull)** for PR 9489 at commit

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-153998372 **[Test build #45109 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45109/consoleFull)** for PR 9489 at commit

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-153998475 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-153998474 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-05 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/9489 [SPARK-11468][SPARKR] add stddev/variance agg functions for Column Checked names, none of them should conflict with anything in base @shivaram @davies @rxin You can merge this pull

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-154202755 **[Test build #45148 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45148/consoleFull)** for PR 9489 at commit

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-154210580 **[Test build #45148 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45148/consoleFull)** for PR 9489 at commit

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-154210731 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-154210733 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-154202141 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11468][SPARKR] add stddev/variance agg ...

2015-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9489#issuecomment-154202114 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not