[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-16 Thread tedyu
Github user tedyu closed the pull request at: https://github.com/apache/spark/pull/9723 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-16 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-157122774 > Sounds like we should prevent the call to StreamingContext#stop() in the listener bus's thread. > How about setting a ThreadLocal Boolean to indicate to StreamingCo

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-16 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156964895 Sounds like we should prevent the call to StreamingContext#stop() in the listener bus's thread. How about setting a ThreadLocal Boolean to indicate to StreamingContext

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156936613 I'm going to revert those commits now to try to unbreak the SBT builds. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156935359 IMO, we should revert https://github.com/apache/spark/commit/3e0a6cf1e02a19b37c68d3026415d53bb57a576b The user should not call `stop` or other long-time work in

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156911334 ``` sbt.ForkMain$ForkError: Test failed with compression using codec org.apache.spark.io.LZ4CompressionCodec: assertion failed: expected groupByKey to spill, b

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156910699 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156910680 **[Test build #45973 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45973/consoleFull)** for PR 9723 at commit [`cd9b2f2`](https://git

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156910700 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156891548 **[Test build #45973 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45973/consoleFull)** for PR 9723 at commit [`cd9b2f2`](https://gith

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156889821 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156889817 **[Test build #45968 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45968/consoleFull)** for PR 9723 at commit [`8be6a7c`](https://git

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156889820 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156889393 **[Test build #45968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45968/consoleFull)** for PR 9723 at commit [`8be6a7c`](https://gith

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156888586 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156888544 **[Test build #45962 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45962/consoleFull)** for PR 9723 at commit [`cb4132d`](https://git

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156888587 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156887216 It's possible that there's a cleaner way to fix the original bug that motivated the incorrect patch vs. trying to patch up the problems introduced by the fix by layeri

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156887130 I'd like @zsxwing to help take a look at this and figure out whether this is a sufficient fix or whether we should revert your original patch and go back to the drawin

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156885497 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156885496 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156885494 **[Test build #45966 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45966/consoleFull)** for PR 9723 at commit [`3df8051`](https://git

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156885326 **[Test build #45966 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45966/consoleFull)** for PR 9723 at commit [`3df8051`](https://gith

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156877667 **[Test build #45962 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45962/consoleFull)** for PR 9723 at commit [`cb4132d`](https://gith

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156870248 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156870241 **[Test build #45961 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45961/consoleFull)** for PR 9723 at commit [`e208c5f`](https://git

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156870251 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156869057 **[Test build #45961 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45961/consoleFull)** for PR 9723 at commit [`e208c5f`](https://gith

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/spark/pull/9723 [SPARK-11572] Process outstanding requests after seeing stop flag This is to address the regression Josh discovered. You can merge this pull request into a Git repository by running: $ git pull h