Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-157154553
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9674#discussion_r44988807
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -200,4 +235,121 @@ class PipelineModel private[ml] (
override def
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9674#discussion_r44990091
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -200,4 +235,121 @@ class PipelineModel private[ml] (
override def
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9674#discussion_r44987093
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -200,4 +235,121 @@ class PipelineModel private[ml] (
override def copy(extra:
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9674#discussion_r44987110
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -200,4 +235,121 @@ class PipelineModel private[ml] (
override def copy(extra:
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9674#discussion_r44987081
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -200,4 +235,121 @@ class PipelineModel private[ml] (
override def copy(extra:
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9674#discussion_r44987116
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -200,4 +235,121 @@ class PipelineModel private[ml] (
override def copy(extra:
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9674#discussion_r44987076
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -200,4 +235,121 @@ class PipelineModel private[ml] (
override def copy(extra:
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9674#discussion_r44987089
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -200,4 +235,121 @@ class PipelineModel private[ml] (
override def copy(extra:
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9674#discussion_r44987052
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -200,4 +235,121 @@ class PipelineModel private[ml] (
override def copy(extra:
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9674#discussion_r44987074
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -200,4 +235,121 @@ class PipelineModel private[ml] (
override def copy(extra:
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9674#discussion_r44987064
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -200,4 +235,121 @@ class PipelineModel private[ml] (
override def copy(extra:
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9674#discussion_r44987039
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -200,4 +235,121 @@ class PipelineModel private[ml] (
override def copy(extra:
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-157179166
One suggestion is to merge `PipelineShardWriter` and `PipelineSharedReader`
into a single object under `object Pipeline`, e.g., called `SharedReadWrite`.
Then move
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9674#discussion_r44983864
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -166,6 +173,34 @@ class Pipeline(override val uid: String) extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-157155290
**[Test build #46012 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46012/consoleFull)**
for PR 9674 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-157169733
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-157169560
**[Test build #46012 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46012/consoleFull)**
for PR 9674 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-157169735
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-157205145
**[Test build #46026 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46026/consoleFull)**
for PR 9674 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-157224892
**[Test build #46026 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46026/consoleFull)**
for PR 9674 at commit
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-157205763
LGTM pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-157225031
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-157225029
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9674#discussion_r44999160
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -200,4 +235,121 @@ class PipelineModel private[ml] (
override def
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-157203769
@mengxr Thanks for reviewing! I believe I addressed everything, except
where I quibbled in responses above.
---
If your project is set up for it, you can reply to
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-157227862
@mengxr Thank you for reviewing! Merging with master and branch-1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9674
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-156537144
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-156537143
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-156568081
**[Test build #45897 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45897/consoleFull)**
for PR 9674 at commit
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-156563935
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-156576715
**[Test build #45897 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45897/consoleFull)**
for PR 9674 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-156577016
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-156577017
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-156221746
**[Test build #45764 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45764/consoleFull)**
for PR 9674 at commit
GitHub user jkbradley opened a pull request:
https://github.com/apache/spark/pull/9674
[SPARK-11612] [ML] Pipeline and PipelineModel persistence
Pipeline and PipelineModel extend Readable and Writable. Persistence
succeeds only when all stages are Writable.
Note: This PR
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-156221139
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-156221102
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-156235842
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-156235845
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9674#issuecomment-156235482
**[Test build #45764 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45764/consoleFull)**
for PR 9674 at commit
42 matches
Mail list logo
