[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9718 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-15 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156859416 Merged into master and 1.6 branch, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156844714 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156844690 **[Test build #45955 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45955/consoleFull)** for PR 9718 at commit [`aadfeab`](https://git

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156844715 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156829687 **[Test build #45955 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45955/consoleFull)** for PR 9718 at commit [`aadfeab`](https://gith

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-15 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156789726 LGTM, and some minor comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9718#discussion_r44868784 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -267,6 +267,55 @@ class CodeGenContext {

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9718#discussion_r44868778 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -267,6 +267,55 @@ class CodeGenContext {

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156789202 **[Test build #45946 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45946/consoleFull)** for PR 9718 at commit [`7228093`](https://git

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156789220 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156789219 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156783662 **[Test build #45946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45946/consoleFull)** for PR 9718 at commit [`7228093`](https://gith

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156783007 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156783008 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156782998 **[Test build #45945 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45945/consoleFull)** for PR 9718 at commit [`f43a7f9`](https://git

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156775646 **[Test build #45945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45945/consoleFull)** for PR 9718 at commit [`f43a7f9`](https://gith

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156768936 **[Test build #45940 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45940/consoleFull)** for PR 9718 at commit [`f5f074d`](https://git

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156768943 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156768942 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156768306 **[Test build #45940 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45940/consoleFull)** for PR 9718 at commit [`f5f074d`](https://gith

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-14 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156767526 @davies take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-14 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9718#discussion_r44866039 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala --- @@ -49,40 +47,6 @@ class CodeGenerationSuite exte

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-14 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9718#discussion_r44866037 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ordering.scala --- @@ -29,35 +30,76 @@ class InterpretedOrdering(ordering: Seq[

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-14 Thread yhuai
GitHub user yhuai opened a pull request: https://github.com/apache/spark/pull/9718 [SPARK-11738] [SQL] Making ArrayType orderable https://issues.apache.org/jira/browse/SPARK-11738 You can merge this pull request into a Git repository by running: $ git pull https://github.com/yh