[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-18 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-157693222 @shivaram @sun-rui Thanks for your review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-157397984 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-157397991 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-157397746 **[Test build #46087 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46087/consoleFull)** for PR 9732 at commit

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-157391272 **[Test build #46087 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46087/consoleFull)** for PR 9732 at commit

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-17 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-157445082 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-17 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-157563943 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-17 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-157613566 Merging this to master, branch-1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9732 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-16 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/9732#discussion_r44952987 --- Diff: R/pkg/R/generics.R --- @@ -1054,6 +1054,10 @@ setGeneric("year", function(x) { standardGeneric("year") }) #' @export setGeneric("glm")

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-16 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/9732 [SPARK-11755] [R] SparkR should export "predict" R users often get help information for a method like this: ```R > ?predict ``` or ```R > help(predict) ``` For

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-16 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-156978307 @mengxr @shivaram @sun-rui --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-156985136 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-156985000 **[Test build #45993 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45993/consoleFull)** for PR 9732 at commit

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-156985142 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-156979683 **[Test build #45993 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45993/consoleFull)** for PR 9732 at commit

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-16 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9732#discussion_r44911837 --- Diff: R/pkg/R/generics.R --- @@ -1054,6 +1054,10 @@ setGeneric("year", function(x) { standardGeneric("year") }) #' @export setGeneric("glm")