Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/9750#discussion_r45495339
--- Diff: R/pkg/R/DataFrame.R ---
@@ -557,7 +548,7 @@ setMethod("unique",
#'
#' @family DataFrame functions
#' @rdname sample
-#' @aliases
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/9750#discussion_r45495256
--- Diff: R/pkg/R/DataFrame.R ---
@@ -254,7 +254,6 @@ setMethod("dtypes",
#' @family DataFrame functions
#' @rdname columns
#' @name columns
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9750#issuecomment-158472753
Thanks @felixcheung -- LGTM. Had some minor inline comments about adding
`seealso` in places where we removed `aliases`
---
If your project is set up for it, you can
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9750#discussion_r45504369
--- Diff: R/pkg/R/DataFrame.R ---
@@ -557,7 +548,7 @@ setMethod("unique",
#'
#' @family DataFrame functions
#' @rdname sample
-#'
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9750#discussion_r45505140
--- Diff: R/pkg/R/DataFrame.R ---
@@ -557,7 +548,7 @@ setMethod("unique",
#'
#' @family DataFrame functions
#' @rdname sample
-#'
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9750#discussion_r45504254
--- Diff: R/pkg/R/DataFrame.R ---
@@ -254,7 +254,6 @@ setMethod("dtypes",
#' @family DataFrame functions
#' @rdname columns
#' @name
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/9750#issuecomment-158334437
OK, got it. LGTM for me. Thanks for your PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9750#issuecomment-158552851
Merging this to master and branch-1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/9750#discussion_r45530831
--- Diff: R/pkg/R/DataFrame.R ---
@@ -557,7 +548,7 @@ setMethod("unique",
#'
#' @family DataFrame functions
#' @rdname sample
-#' @aliases
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9750
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/9750#issuecomment-158299954
Sorry for late response. It can fix my issue mentioned at JIRA. But I also
found new issues that the generated doc of ```describe``` will include the
```summary```
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9750#issuecomment-158300696
It actually is a common practice to include function for types on the same
help page of the function name.
As you can see
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9750#issuecomment-157860823
@yu-iskw would love to have your feedback
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9750#issuecomment-157916296
any more comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9750#issuecomment-157976577
@yanboliang Could you help us review this PR by trying it out and seeing if
it fixes the issue ?
---
If your project is set up for it, you can reply to this email and
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9750#issuecomment-157445230
cc @sun-rui
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9750#issuecomment-157512986
this PR is documentation only, no code change here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/9750
[SPARK-11756][SPARKR] Fix use of aliases - SparkR can not output help
information for SparkR:::summary correctly
Fix use of aliases and changes uses of @rdname and @seealso
`@aliases` is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9750#issuecomment-157224904
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9750#issuecomment-157224908
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9750#issuecomment-157220958
**[Test build #46034 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46034/consoleFull)**
for PR 9750 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9750#issuecomment-157224780
**[Test build #46034 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46034/consoleFull)**
for PR 9750 at commit
22 matches
Mail list logo
