[GitHub] spark pull request: [SPARK-11803][SQL] fix Dataset self-join

Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9806#issuecomment-157749632 Your code looks pretty clean to me. Let me share my test cases this PR failed. ``` test("joinWith tuple - self join 1") { val ds = Seq(("a", 1),

[GitHub] spark pull request: [SPARK-11803][SQL] fix Dataset self-join

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9806 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11803][SQL] fix Dataset self-join

Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9806#issuecomment-157807682 Sure. Will do. Thanks! 2015-11-18 10:16 GMT-08:00 Michael Armbrust : > LGTM, merging to master and 1.6. > >

[GitHub] spark pull request: [SPARK-11803][SQL] fix Dataset self-join

Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9806#issuecomment-157806994 LGTM, merging to master and 1.6. @gatorsmile please open JIRAs targeted at 1.6.0 for the bugs you have found. (also use `checkAnswer` when writing test

[GitHub] spark pull request: [SPARK-11803][SQL] fix Dataset self-join

GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/9806 [SPARK-11803][SQL] fix Dataset self-join When we resolve the join operator, we may change the output of right side if self-join is detected. So in `Dataset.joinWith`, we should resolve the join

[GitHub] spark pull request: [SPARK-11803][SQL] fix Dataset self-join

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9806#issuecomment-157688640 **[Test build #46210 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46210/consoleFull)** for PR 9806 at commit

[GitHub] spark pull request: [SPARK-11803][SQL] fix Dataset self-join

Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9806#issuecomment-157688048 cc @marmbrus @rxin @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11803][SQL] fix Dataset self-join

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9806#issuecomment-157723520 **[Test build #46210 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46210/consoleFull)** for PR 9806 at commit

[GitHub] spark pull request: [SPARK-11803][SQL] fix Dataset self-join

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9806#issuecomment-157723872 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11803][SQL] fix Dataset self-join

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9806#issuecomment-157723869 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your