Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-163365306
Should this be closed now that https://github.com/apache/spark/pull/9961 is
merged?
---
If your project is set up for it, you can reply to this email and have your
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-163367236
Yes, using the magic words: do you mind closing this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user dilipbiswal closed the pull request at:
https://github.com/apache/spark/pull/9844
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-163369667
@srowen closed. Sorry to have missed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-159499937
@cloud-fan Thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9844#discussion_r45705657
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -217,5 +217,23 @@ class AnalysisSuite extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-159191093
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-159191091
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-159191057
**[Test build #46588 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46588/consoleFull)**
for PR 9844 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-159191926
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-159191928
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/9844#discussion_r45715703
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -217,5 +217,23 @@ class AnalysisSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9844#discussion_r45700102
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -610,9 +610,9 @@ class Analyzer(
*/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9844#discussion_r45700402
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -661,7 +666,9 @@ class Analyzer(
val
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/9844#discussion_r45701500
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -661,7 +666,9 @@ class Analyzer(
val
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9844#discussion_r45702258
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -661,7 +666,9 @@ class Analyzer(
val
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/9844#discussion_r45691681
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -661,7 +666,9 @@ class Analyzer(
val
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-159136027
**[Test build #46580 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46580/consoleFull)**
for PR 9844 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-159139182
**[Test build #46580 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46580/consoleFull)**
for PR 9844 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-159139215
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-159139214
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-159186937
**[Test build #46588 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46588/consoleFull)**
for PR 9844 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-159187032
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-159188789
@cloud-fan can you please help trigger a retest ? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-159187034
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-159188818
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-158869241
Thanks a lot @cloud-fan. Actually i do remember trying to do something
similar. So i had tried to filter on resolved and was trying to only pick
un-resolved
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-158870885
how about this:
```
val unresolvedSortOrders = sortOrders.filterNot(_.resolved)
val resolvedSortOrders = ... // the original logic that copy to aggregate
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-158871599
@cloud-fan Wow.. thank you very much. I will try it. Thanks again,
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-158846201
In
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-158837039
@cloud-fan Thank you for the explanation as always. Trying to see if i
understood your suggestion properly. Were you suggesting to add another case
under
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-158831881
This is really a good catch, thanks @dilipbiswal
The problems is that, normal operator should be resolved based on its
child, but `Sort` operator can be
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-158351303
**[Test build #46405 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46405/consoleFull)**
for PR 9844 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-158351431
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-158351430
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-158320803
**[Test build #46405 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46405/consoleFull)**
for PR 9844 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-158255401
**[Test build #46383 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46383/consoleFull)**
for PR 9844 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-158254009
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-158205318
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/9844
[SPARK-11863][SQL][WIP] Unable to resolve order by if it contains mixture
of aliases and real columns.
Compute the evaluatedOrderings by replacing the Alias names referenced by
Sort
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-158205174
@cloud-fan Hi Wenchen, can you please look at this change and let me know
your comments.
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-158271745
**[Test build #46383 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46383/consoleFull)**
for PR 9844 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-158271821
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9844#issuecomment-158271825
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
44 matches
Mail list logo
