Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159692827
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159695431
**[Test build #46696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46696/consoleFull)**
for PR 9917 at commit
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159715344
> By the way, I have confirmed that skipping the ack (this patch) increases
scheduler throughput by about 17%.
Cool!
---
If your project is set up for it, you
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159712567
@vanzin can you open the same patch against branch-1.6?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159710121
LGTM. Thanks @vanzin The codes are much cleaner :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159713074
By the way, I have confirmed that skipping the ack (this patch) increases
scheduler throughput by about 17%.
---
If your project is set up for it, you can reply to
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159715782
I'll wait for the tests just to be sure. Also, if there are no conflicts, I
plan to just merge into 1.6, if that's ok.
---
If your project is set up for it, you can
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9917
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159726699
**[Test build #46696 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46696/consoleFull)**
for PR 9917 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159727034
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159727033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159720021
Yeah, if there are no conflicts then feel free to do so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9917#discussion_r45803244
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
---
@@ -208,46 +193,52 @@ private[netty] class NettyRpcEnv(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9917#discussion_r45806519
--- Diff:
network/common/src/main/java/org/apache/spark/network/server/RpcHandler.java ---
@@ -48,10 +54,40 @@ public abstract void receive(
public
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9917#discussion_r45802966
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
---
@@ -208,46 +193,52 @@ private[netty] class NettyRpcEnv(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9917#discussion_r45802883
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/Outbox.scala ---
@@ -22,13 +22,51 @@ import javax.annotation.concurrent.GuardedBy
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9917#discussion_r45803744
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/ExecutorRunner.scala ---
@@ -92,7 +92,11 @@ private[deploy] class ExecutorRunner(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159436295
**[Test build #46636 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46636/consoleFull)**
for PR 9917 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9917#discussion_r45807174
--- Diff:
network/common/src/main/java/org/apache/spark/network/server/RpcHandler.java ---
@@ -48,10 +54,40 @@ public abstract void receive(
public
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9917#discussion_r45808289
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/ExecutorRunner.scala ---
@@ -92,7 +92,11 @@ private[deploy] class ExecutorRunner(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9917#discussion_r45803809
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/Dispatcher.scala
---
@@ -106,44 +106,39 @@ private[netty] class Dispatcher(nettyEnv:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9917#discussion_r45805486
--- Diff:
network/common/src/main/java/org/apache/spark/network/server/RpcHandler.java ---
@@ -48,10 +54,40 @@ public abstract void receive(
public
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9917#discussion_r45803882
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/Dispatcher.scala
---
@@ -106,44 +106,39 @@ private[netty] class Dispatcher(nettyEnv:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9917#discussion_r45803544
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/Outbox.scala ---
@@ -22,13 +22,51 @@ import javax.annotation.concurrent.GuardedBy
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159433830
@vanzin I think this looks pretty good. It simplifies a lot of the existing
code and makes `send` much simpler. In fact, I think this will help mitigate
the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159439405
**[Test build #46640 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46640/consoleFull)**
for PR 9917 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159457933
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159457881
**[Test build #46640 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46640/consoleFull)**
for PR 9917 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159457934
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159477569
**[Test build #46636 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46636/consoleFull)**
for PR 9917 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159477599
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159477601
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/9917
[SPARK-11866] [network] [core] Make sure timed out RPCs are cleaned up.
This change does a couple of different things to make sure that the
RpcEnv-level
code and the network library agree about
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159086472
**[Test build #46557 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46557/consoleFull)**
for PR 9917 at commit
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159085929
/cc @rxin @zsxwing
While this problem also exists in 1.6, I didn't make this patch with the
intent of putting it there. If there's a desire to fix this in 1.6,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159151618
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159151566
**[Test build #46582 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46582/consoleFull)**
for PR 9917 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159151619
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159139381
**[Test build #46582 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46582/consoleFull)**
for PR 9917 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159134283
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159134285
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159134234
**[Test build #46557 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46557/consoleFull)**
for PR 9917 at commit
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9917#issuecomment-159137841
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
43 matches
Mail list logo
